cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed unnecessary 'return' statements. (#3653)

Browse Source 
* Removed unnecessary 'return' statements.

Returning a 'Promise' value in 'promise.then()' makes promise chains.
Used memory and promises are not garbage collected
until finishing 'helpers.asyncToGenerator'.

* Update test
This commit is contained in:
Kay J
2016-09-26 05:57:59 +09:00
committed by Logan Smyth
parent 66a4aec1f9
commit 4dcc981d6a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-core/test/fixtures/transformation/misc/regression-2892/expected.js vendored
View File

@@ -46,7 +46,7 @@ var foo = function () {
};
}();
function _asyncToGenerator(fn) { return function () { var gen = fn.apply(this, arguments); return new Promise(function (resolve, reject) { function step(key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { return Promise.resolve(value).then(function (value) { return step("next", value); }, function (err) { return step("throw", err); }); } } return step("next"); }); }; }
function _asyncToGenerator(fn) { return function () { var gen = fn.apply(this, arguments); return new Promise(function (resolve, reject) { function step(key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { return Promise.resolve(value).then(function (value) { step("next", value); }, function (err) { step("throw", err); }); } } return step("next"); }); }; }
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }

4
packages/babel-helpers/src/helpers.js
View File

@@ -79,9 +79,9 @@ helpers.asyncToGenerator = template(`
resolve(value);
} else {
return Promise.resolve(value).then(function (value) {
return step("next", value);
step("next", value);
}, function (err) {
return step("throw", err);
step("throw", err);
});
}
}