From 4dcc981d6aa5460552af4b96fa9148bee64c2a24 Mon Sep 17 00:00:00 2001 From: Kay J Date: Mon, 26 Sep 2016 05:57:59 +0900 Subject: [PATCH] Removed unnecessary 'return' statements. (#3653) * Removed unnecessary 'return' statements. Returning a 'Promise' value in 'promise.then()' makes promise chains. Used memory and promises are not garbage collected until finishing 'helpers.asyncToGenerator'. * Update test --- .../fixtures/transformation/misc/regression-2892/expected.js | 2 +- packages/babel-helpers/src/helpers.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/babel-core/test/fixtures/transformation/misc/regression-2892/expected.js b/packages/babel-core/test/fixtures/transformation/misc/regression-2892/expected.js index 9a63bc4a25..9047cffccf 100644 --- a/packages/babel-core/test/fixtures/transformation/misc/regression-2892/expected.js +++ b/packages/babel-core/test/fixtures/transformation/misc/regression-2892/expected.js @@ -46,7 +46,7 @@ var foo = function () { }; }(); -function _asyncToGenerator(fn) { return function () { var gen = fn.apply(this, arguments); return new Promise(function (resolve, reject) { function step(key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { return Promise.resolve(value).then(function (value) { return step("next", value); }, function (err) { return step("throw", err); }); } } return step("next"); }); }; } +function _asyncToGenerator(fn) { return function () { var gen = fn.apply(this, arguments); return new Promise(function (resolve, reject) { function step(key, arg) { try { var info = gen[key](arg); var value = info.value; } catch (error) { reject(error); return; } if (info.done) { resolve(value); } else { return Promise.resolve(value).then(function (value) { step("next", value); }, function (err) { step("throw", err); }); } } return step("next"); }); }; } function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } } diff --git a/packages/babel-helpers/src/helpers.js b/packages/babel-helpers/src/helpers.js index 000360432f..d70abc2f6a 100644 --- a/packages/babel-helpers/src/helpers.js +++ b/packages/babel-helpers/src/helpers.js @@ -79,9 +79,9 @@ helpers.asyncToGenerator = template(` resolve(value); } else { return Promise.resolve(value).then(function (value) { - return step("next", value); + step("next", value); }, function (err) { - return step("throw", err); + step("throw", err); }); } }