v3.0.12

CHANGELOG.md

@@ -11,6 +11,30 @@
 
 _Note: Gaps between patch versions are faulty/broken releases._
 
+## 3.0.12
+
+ * **Internal**
+  * Add internal debug messages.
+ * **Bug Fix**
+  * Add `noScope` option to `traverse.clearProperties`.
+
+## 3.0.11
+
+ * **Bug Fix**
+  * Fix `ast-types` `RestElement` definition.
+  * Make `es6.forOf` loose mode more versatile and support destructuring.
+
+## 3.0.10
+
+ * **Bug Fix**
+  * In `types.getIds` make sure the `declaration` inside of `ExportDeclaration` is actually a `Declaration`.
+
+## 3.0.9
+
+ * **Bug Fix**
+  * Make `t.isReferenced` more powerful, actually take into consideration all contexts were identifier nodes aren't actually references.
+  * Don't camelcase underscores when converting a string to a valid identifier.
+
 ## 3.0.8
 
  * **Bug Fix**

lib/6to5/file.js

@@ -323,6 +323,8 @@ File.prototype.parse = function (code) {
 File.prototype.transform = function (ast) {
   var self = this;
 
+  util.debug(this.opts.filename);
+
   this.ast = ast;
   this.lastStatements = t.getLastStatements(ast.program);
   this.scope = new Scope(ast.program, ast, null, this);

lib/6to5/patch.js

@@ -34,9 +34,9 @@ def("ImportBatchSpecifier")
   .field("name", def("Identifier"));
 
 def("RestElement")
-  .bases("Node")
+  .bases("Pattern")
   .build("argument")
-  .field("argument", def("Pattern"));
+  .field("argument", def("expression"));
 
 // Abstract references
 def("VirtualPropertyExpression")

lib/6to5/transformation/templates/for-of-loose.js

@@ -2,6 +2,7 @@ for (var LOOP_OBJECT = OBJECT,
          IS_ARRAY = Array.isArray(LOOP_OBJECT),
          INDEX = 0,
          LOOP_OBJECT = IS_ARRAY ? LOOP_OBJECT : LOOP_OBJECT[Symbol.iterator]();;) {
+  var ID;
   if (IS_ARRAY) {
     if (INDEX >= LOOP_OBJECT.length) break;
     ID = LOOP_OBJECT[INDEX++];

lib/6to5/transformation/transformer-pass.js

@@ -1,6 +1,7 @@
 module.exports = TransformerPass;
 
 var traverse = require("../traverse");
+var util     = require("../util");
 var _        = require("lodash");
 
 /**
@@ -60,6 +61,8 @@ var transformVisitor = {
 TransformerPass.prototype.transform = function () {
   var file = this.file;
 
+  util.debug(file.opts.filename + ": Running transformer " + this.transformer.key);
+
   this.astRun("before");
 
   var state = { file: file, handlers: this.handlers, pass: this };

lib/6to5/transformation/transformers/es6/for-of.js

@@ -20,11 +20,7 @@ exports.ForOfStatement = function (node, parent, scope, context, file) {
 
   // add the value declaration to the new loop body
   if (declar) {
-    if (build.shouldUnshift) {
-      block.body.unshift(declar);
-    } else {
-      block.body.push(declar);
-    }
+    block.body.push(declar);
   }
 
   // push the rest of the original loop body onto our new body
@@ -45,9 +41,9 @@ var loose = function (node, parent, scope, context, file) {
     id = left;
   } else if (t.isVariableDeclaration(left)) {
     // for (var i of test)
-    id = left.declarations[0].id;
+    id = scope.generateUidIdentifier("ref");
     declar = t.variableDeclaration(left.kind, [
-      t.variableDeclarator(id)
+      t.variableDeclarator(left.declarations[0].id, id)
     ]);
   } else {
     throw file.errorWithNode(left, "Unknown node type " + left.type + " in ForOfStatement");
@@ -61,10 +57,15 @@ var loose = function (node, parent, scope, context, file) {
     ID:           id
   });
 
+  if (!declar) {
+    // no declaration so we need to remove the variable declaration at the top of
+    // the for-of-loose template
+    loop.body.body.shift();
+  }
+
   return {
-    shouldUnshift: true,
-    declar:        declar,
-    loop:          loop
+    declar: declar,
+    loop:   loop
   };
 };
 

lib/6to5/transformation/transformers/es6/parameters.rest.js

@@ -12,8 +12,6 @@ exports.Function = function (node, parent, scope) {
 
   var rest = node.params.pop().argument;
 
-  t.ensureBlock(node);
-
   var argsId = t.identifier("arguments");
 
   // otherwise `arguments` will be remapped in arrow functions

lib/6to5/transformation/transformers/internal/modules-split.js

@@ -1,5 +1,11 @@
 "use strict";
 
+// in this transformer we have to split up classes and function declarations
+// from their exports. why? because sometimes we need to replace classes with
+// nodes that aren't allowed in the same contexts. also, if you're exporting
+// a generator function as a default then regenerator will destroy the export
+// declaration and leave a variable declaration in it's place... yeah, handy.
+
 var t = require("../../../types");
 
 exports.ExportDeclaration = function (node, parent, scope) {

lib/6to5/traverse/index.js

@@ -110,7 +110,7 @@ TraversalContext.prototype.visitNode = function (obj, key, opts, scope, parent,
 
   var ourScope = scope;
   // we're entering a new scope so let's construct it!
-  if (t.isScope(node)) {
+  if (!opts.noScope && t.isScope(node)) {
     ourScope = new Scope(node, parent, scope);
   }
 
@@ -177,7 +177,7 @@ function traverseNode(node, opts, scope, state) {
 function traverse(parent, opts, scope, state) {
   if (!parent) return;
 
-  if (!scope) {
+  if (!opts.noScope && !scope) {
     if (parent.type !== "Program" && parent.type !== "File") {
       throw new Error("Must pass a scope unless traversing a Program/File got a " + parent.type + " node");
     }
@@ -217,7 +217,10 @@ function clearNode(node) {
   }
 }
 
-var clearVisitor = { enter: clearNode };
+var clearVisitor = {
+  noScope: true,
+  enter: clearNode
+};
 
 function clearComments(comments) {
   for (var i = 0; i < comments.length; i++) {

lib/6to5/types/index.js

@@ -226,7 +226,7 @@ t.prependToMemberExpression = function (member, append) {
 };
 
 /**
- * Description
+ * Check if the input `node` is a reference to a bound variable.
  *
  * @param {Object} node
  * @param {Object} parent
@@ -234,45 +234,94 @@ t.prependToMemberExpression = function (member, append) {
  */
 
 t.isReferenced = function (node, parent) {
-  // we're a property key and we aren't computed so we aren't referenced
-  if (t.isProperty(parent) && parent.key === node && !parent.computed) return false;
-
-  if (t.isFunction(parent)) {
-    // we're a function param
-    if (_.contains(parent.params, node)) return false;
-
-    for (var i = 0; i < parent.params.length; i++) {
-      var param = parent.params[i];
-      if (param === node) {
-        return false;
-      } else if (t.isRestElement(param) && param.argument === node) {
-        return false;
-      }
+  // yes: PARENT[NODE]
+  // yes: NODE.child
+  // no: parent.CHILD
+  if (t.isMemberExpression(parent)) {
+    if (parent.property === node && parent.computed) {
+      return true;
+    } else if (parent.object === node) {
+      return true;
+    } else {
+      return false;
     }
   }
 
-  if (t.isMethodDefinition(parent) && parent.key === node && !parent.computed) {
+  // yes: { [NODE]: "" }
+  if (t.isProperty(parent)) {
+    return parent.key === node && parent.computed;
+  }
+
+  // no: var NODE = init;
+  // yes: var id = NODE;
+  if (t.isVariableDeclarator(parent)) {
+    return parent.id !== node;
+  }
+
+  // no: function NODE() {}
+  // no: function foo(NODE) {}
+  if (t.isFunction(parent)) {
+    for (var i = 0; i < parent.params.length; i++) {
+      var param = parent.params[i];
+      if (param === node) return false;
+    }
+
+    return parent.id !== node;
+  }
+
+  // no: class NODE {}
+  if (t.isClass(parent)) {
+    return parent.id !== node;
+  }
+
+  // yes: class { [NODE](){} }
+  if (t.isMethodDefinition(parent)) {
+    return parent.key === node && parent.computed;
+  }
+
+  // no: NODE: for (;;) {}
+  if (t.isLabeledStatement(parent)) {
     return false;
   }
 
-  // we're a catch clause param
-  if (t.isCatchClause(parent) && parent.param === node) return false;
+  // no: try {} catch (NODE) {}
+  if (t.isCatchClause(parent)) {
+    return parent.param !== node;
+  }
 
-  // we're a variable declarator id so we aren't referenced
-  if (t.isVariableDeclarator(parent) && parent.id === node) return false;
+  // no: function foo(...NODE) {}
+  if (t.isRestElement(parent)) {
+    return false;
+  }
 
-  var isMemberExpression = t.isMemberExpression(parent);
+  // no: [NODE = foo] = [];
+  // yes: [foo = NODE] = [];
+  if (t.isAssignmentPattern(parent)) {
+    return parent.right !== node;
+  }
 
-  // we're in a member expression and we're the computed property so we're referenced
-  var isComputedProperty = isMemberExpression && parent.property === node && parent.computed;
+  // no: [NODE] = [];
+  // no: ({ NODE }) = [];
+  if (t.isPattern(parent)) {
+    return false;
+  }
 
-  // we're in a member expression and we're the object so we're referenced
-  var isObject = isMemberExpression && parent.object === node;
+  // no: import NODE from "bar";
+  if (t.isImportSpecifier(parent)) {
+    return false;
+  }
 
-  // we are referenced
-  if (!isMemberExpression || isComputedProperty || isObject) return true;
+  // no: import * as NODE from "foo";
+  if (t.isImportBatchSpecifier(parent)) {
+    return false;
+  }
 
-  return false;
+  // no: class Foo { private NODE; }
+  if (t.isPrivateDeclaration(parent)) {
+    return false;
+  }
+
+  return true;
 };
 
 /**
@@ -317,13 +366,10 @@ t.toIdentifier = function (name) {
   name = name.replace(/^[-0-9]+/, "");
 
   // camel case
-  name = name.replace(/[-_\s]+(.)?/g, function (match, c) {
+  name = name.replace(/[-\s]+(.)?/g, function (match, c) {
     return c ? c.toUpperCase() : "";
   });
 
-  // remove underscores from start of name
-  name = name.replace(/^\_/, "");
-
   if (!t.isValidIdentifier(name)) {
     name = "_" + name;
   }
@@ -444,7 +490,11 @@ t.toBlock = function (node, parent) {
 };
 
 /**
- * Description
+ * Return a list of identifiers that will be assigned
+ * as a result of runtime evaluation.
+ *
+ * If an identifier is passed as `node` instead of a
+ * declaration then it's assumed to be an assignable.
  *
  * @param {Object} node
  * @param {Boolean} [map]
@@ -453,15 +503,15 @@ t.toBlock = function (node, parent) {
  */
 
 t.getIds = function (node, map, ignoreTypes) {
-  ignoreTypes = ignoreTypes || [];
-
   var search = [].concat(node);
   var ids    = object();
 
   while (search.length) {
     var id = search.shift();
     if (!id) continue;
-    if (_.contains(ignoreTypes, id.type)) continue;
+
+    // blacklist types
+    if (ignoreTypes && ignoreTypes.indexOf(id.type) >= 0) continue;
 
     var nodeKeys = t.getIds.nodes[id.type];
     var arrKeys  = t.getIds.arrays[id.type];
@@ -470,6 +520,10 @@ t.getIds = function (node, map, ignoreTypes) {
 
     if (t.isIdentifier(id)) {
       ids[id.name] = id;
+    } else if (t.isExportDeclaration(id)) {
+      if (t.isDeclaration(node.declaration)) {
+        search.push(node.declaration);
+      }
     } else if (nodeKeys) {
       for (i = 0; i < nodeKeys.length; i++) {
         key = nodeKeys[i];
@@ -509,7 +563,6 @@ t.getIds.nodes = {
 t.getIds.arrays = {
   PrivateDeclaration: ["declarations"],
   ComprehensionExpression: ["blocks"],
-  ExportDeclaration: ["specifiers", "declaration"],
   ImportDeclaration: ["specifiers"],
   VariableDeclaration: ["declarations"],
   ArrayPattern: ["elements"],

lib/6to5/util.js

@@ -5,6 +5,7 @@ require("./patch");
 var estraverse = require("estraverse");
 var codeFrame  = require("./helpers/code-frame");
 var traverse   = require("./traverse");
+var debug      = require("debug");
 var acorn      = require("acorn-6to5");
 var path       = require("path");
 var util       = require("util");
@@ -14,6 +15,8 @@ var _          = require("lodash");
 
 exports.inherits = util.inherits;
 
+exports.debug = debug("6to5");
+
 exports.canCompile = function (filename, altExts) {
   var exts = altExts || exports.canCompile.EXTENSIONS;
   var ext = path.extname(filename);

package.json

@@ -1,7 +1,7 @@
 {
   "name": "6to5",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "3.0.8",
+  "version": "3.0.12",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://6to5.org/",
   "repository": "6to5/6to5",
@@ -38,6 +38,7 @@
     "chokidar": "0.12.6",
     "commander": "2.6.0",
     "core-js": "^0.4.9",
+    "debug": "^2.1.1",
     "detect-indent": "3.0.0",
     "estraverse": "1.9.1",
     "esutils": "1.1.6",

packages/6to5-runtime/package.json

@@ -1,7 +1,7 @@
 {
   "name": "6to5-runtime",
   "description": "6to5 selfContained runtime",
-  "version": "3.0.7",
+  "version": "3.0.11",
   "repository": "6to5/6to5",
   "author": "Sebastian McKenzie <sebmck@gmail.com>"
-}
+}

test/_transformation-helper.js

@@ -1,6 +1,7 @@
 var genHelpers = require("./_generator-helpers");
 var transform  = require("../lib/6to5/transformation/transform");
 var sourceMap  = require("source-map");
+var codeFrame  = require("../lib/6to5/helpers/code-frame");
 var esvalid    = require("esvalid");
 var Module     = require("module");
 var helper     = require("./_helper");
@@ -85,7 +86,7 @@ var run = function (task, done) {
       fn.call(global, fakeRequire, chai.assert, done);
     } catch (err) {
       err.message = exec.loc + ": " + err.message;
-      err.message += util.codeFrame(execCode);
+      err.message += codeFrame(execCode);
       throw err;
     }
   }

test/fixtures/transformation/es6-for-of-loose/let/expected.js

@@ -1,13 +1,14 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i = undefined;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
-}
+  var i = _ref;
+}

test/fixtures/transformation/es6-for-of-loose/multiple/expected.js

@@ -1,25 +1,27 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
+  var i = _ref;
 }
 
 for (var _iterator2 = numbers, _isArray2 = Array.isArray(_iterator2), _i2 = 0, _iterator2 = _isArray2 ? _iterator2 : _iterator2[Symbol.iterator]();;) {
-  var i;
+  var _ref2;
   if (_isArray2) {
     if (_i2 >= _iterator2.length) break;
-    i = _iterator2[_i2++];
+    _ref2 = _iterator2[_i2++];
   } else {
     _i2 = _iterator2.next();
     if (_i2.done) break;
-    i = _i2.value;
+    _ref2 = _i2.value;
   }
-}
+  var i = _ref2;
+}

test/fixtures/transformation/es6-for-of-loose/var/expected.js

@@ -1,13 +1,14 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
-}
+  var i = _ref;
+}

test/fixtures/transformation/regenerator/default-parameters/exec.js

@@ -0,0 +1,6 @@
+function* foo(bar = "bar") {
+  return bar;
+}
+
+assert.deepEqual(foo().next().value, "bar");
+assert.deepEqual(foo("foo").next().value, "foo");

test/fixtures/transformation/regenerator/destructuring/exec.js

@@ -0,0 +1,5 @@
+function* foo({ bar }) {
+  return bar;
+}
+
+assert(foo({ bar: "bar" }).next().value, "bar");

test/fixtures/transformation/regenerator/rest-parameters/exec.js

@@ -0,0 +1,5 @@
+function* foo(...items) {
+  return items;
+}
+
+assert.deepEqual(foo(1, 2, 3).next().value, [1, 2, 3]);