cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Verify if MemberExpression is computed

Browse Source 
If a property access is computed, e.g. a[b], then it's in topic style. Currently,
this isn't accounted for. Test & change ensures this doesn't parse.
This commit is contained in:
James DiGioia
2018-08-10 08:06:38 -04:00
parent 25d01460fd
commit 122906d525
5 changed files with 7 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-parser/src/parser/expression.js
View File

@@ -2100,7 +2100,9 @@ export default class ExpressionParser extends LValParser {
isSimpleReference(expression: N.Expression): boolean {
switch (expression.type) {
case "MemberExpression":
return this.isSimpleReference(expression.object);
return (
!expression.computed && this.isSimpleReference(expression.object)
);
case "Identifier":
return true;
default:

3
packages/babel-parser/test/fixtures/experimental/pipeline-operator/proposal-smart-bare-style,-function-calls,-single,-computed/options.json vendored
View File

@@ -1,3 +0,0 @@
{
"plugins": [["pipelineOperator", { "proposal": "smart" }]]
}

148
packages/babel-parser/test/fixtures/experimental/pipeline-operator/proposal-smart-bare-style,-function-calls,-single,-computed/output.json vendored
View File

@@ -1,148 +0,0 @@
{
"type": "File",
"start": 0,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 13
}
},
"program": {
"type": "Program",
"start": 0,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 13
}
},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start": 0,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 13
}
},
"expression": {
"type": "BinaryExpression",
"start": 0,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 13
}
},
"left": {
"type": "Identifier",
"start": 0,
"end": 5,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 5
},
"identifierName": "value"
},
"name": "value"
},
"operator": "|>",
"right": {
"type": "PipelineBareFunction",
"start": 9,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 13
}
},
"callee": {
"type": "MemberExpression",
"start": 9,
"end": 13,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 13
}
},
"object": {
"type": "Identifier",
"start": 9,
"end": 10,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 10
},
"identifierName": "a"
},
"name": "a"
},
"property": {
"type": "Identifier",
"start": 11,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 11
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "b"
},
"name": "b"
},
"computed": true
}
}
}
}
],
"directives": []
}
}

0
packages/babel-parser/test/fixtures/experimental/pipeline-operator/proposal-smart-bare-style,-function-calls,-single,-computed/input.js → packages/babel-parser/test/fixtures/experimental/pipeline-operator/proposal-smart-error,-topic-style,-computed,-no-topic-reference/input.js vendored
View File

4
packages/babel-parser/test/fixtures/experimental/pipeline-operator/proposal-smart-error,-topic-style,-computed,-no-topic-reference/options.json vendored Normal file
View File

@@ -0,0 +1,4 @@
{
"plugins": [["pipelineOperator", { "proposal": "smart" }]],
"throws": "Pipeline is in topic style but does not use topic reference (1:9)"
}