7 Commits

Author SHA1 Message Date
Leosvel Pérez Espinosa
b699207070
fix(linter): update the @nx/dependency-checks rule to read the package.json content from the rule context (#27476)
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

The `@nx/dependency-checks` rule sometimes doesn't apply all identified
fixes and wrongly succeeds. ESLint performs multiple passes to try to
apply fixes, and in each pass the rule receives the updated source code
with the previously applied fixes. This allows merging different fixes,
but the `@nx/dependency-checks` rule always reads the `package.json`
file from the filesystem, caches it globally, and mutates it. It never
uses the updated source code provided in the rule context.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The `@nx/dependency-checks` rule should apply all identified fixes [as
long as they don't
conflict](https://eslint.org/docs/latest/extend/custom-rules#conflicting-fixes).

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #27412
2024-08-16 17:14:09 +02:00
Miroslav Jonaš
a0ae902e4e
fix(linter): prevent dep-checks leaking when used outside nx (#21404) 2024-02-02 14:22:52 +01:00
Miroslav Jonaš
2bc7031017
fix(linter): fix dep-checks projPackageJsonDeps caching for IDE (#18935) 2023-09-06 10:19:50 +02:00
Jack Hsu
9ffea2bb1b
fix(linter): error on dependencies that are only in devDependencies instead of production dependencies (#18780) 2023-08-22 23:05:53 +02:00
Jack Hsu
ae773d547e
fix(linter): skip verifying deps of deps by default in package.json (#18058) 2023-07-12 20:59:36 -04:00
Miroslav Jonaš
28a071f243
fix(js): ignore dependencies from non-index root files for create-package-json (#17930) 2023-07-05 17:47:49 +02:00
Miroslav Jonaš
ef8c4ed095
feat(linter): add rule for dependency checking (#17581) 2023-06-23 10:26:44 -04:00