miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

feat(storybook): upgrade @storybook/test-runner to 0.19 (#28959)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
I got this error locally, I think it is because @storybook/test-runner
is incompatible with storybook version
https://github.com/storybookjs/test-runner/issues/505
<img width="1147" alt="Screenshot 2024-11-15 at 12 22 13 PM"
src="https://github.com/user-attachments/assets/e2a9f4c9-e784-4946-8677-b60b62ff36ef">

from https://github.com/storybookjs/test-runner#storybook-compatibility
storybook ^8.2.0 should use @storybook/test-runner ^0.19.0

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Emily Xiong 2024-11-18 02:07:44 -08:00 committed by GitHub
parent 8efad63f86
commit eb143d3ed6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/storybook/migrations.json
View File

@ -283,6 +283,19 @@
"storybook": { "storybook": {
"version": "^8.2.8", "version": "^8.2.8",
"alwaysAddToPackageJson": true "alwaysAddToPackageJson": true
},
"@storybook/test-runner": {
"version": "^0.19.0",
"alwaysAddToPackageJson": false
}
}
},
"20.2.0": {
"version": "20.2.0-beta.3",
"packages": {
"@storybook/test-runner": {
"version": "^0.19.0",
"alwaysAddToPackageJson": false
} }
} }
} }

2
packages/storybook/src/utils/versions.ts
View File

@ -1,5 +1,5 @@
export const nxVersion = require('../../package.json').version; export const nxVersion = require('../../package.json').version;
export const storybookTestRunnerVersion = '^0.13.0'; export const storybookTestRunnerVersion = '^0.19.0';
export const storybookTestingLibraryVersion = '^0.2.2'; export const storybookTestingLibraryVersion = '^0.2.2';
export const storybookJestVersion = '^0.2.3'; export const storybookJestVersion = '^0.2.3';
export const litVersion = '^2.6.1'; export const litVersion = '^2.6.1';