miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(testing): accept a numeric value for the playwright executor's workers option (#26689)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26437
This commit is contained in:
Leosvel Pérez Espinosa 2024-06-26 16:08:39 +02:00 committed by GitHub
parent c24c20e990
commit d3383caad3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/generated/packages/playwright/executors/playwright.json
View File

@ -63,7 +63,7 @@
}, },
"workers": { "workers": {
"alias": "j", "alias": "j",
"type": "string", "oneOf": [{ "type": "number" }, { "type": "string" }],
"description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker" "description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker"
}, },
"list": { "list": {

2
packages/playwright/src/executors/playwright/playwright.impl.ts
View File

@ -23,7 +23,7 @@ export interface PlaywrightExecutorSchema {
testFiles?: string[]; testFiles?: string[];
headed?: boolean; headed?: boolean;
ignoreSnapshots?: boolean; ignoreSnapshots?: boolean;
workers?: string; workers?: number | string;
list?: boolean; list?: boolean;
maxFailures?: number | boolean; maxFailures?: number | boolean;
noDeps?: boolean; noDeps?: boolean;

2
packages/playwright/src/executors/playwright/schema.json
View File

@ -62,7 +62,7 @@
}, },
"workers": { "workers": {
"alias": "j", "alias": "j",
"type": "string", "oneOf": [{ "type": "number" }, { "type": "string" }],
"description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker" "description": "Number of concurrent workers or percentage of logical CPU cores, use 1 to run in a single worker"
}, },
"list": { "list": {