miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(module-federation): the module federation package depends on rspack (#30520)

Browse Source 
## Current Behavior
The `@nx/module-federation` depends on the `@rspack/core` package but it
is currently only set as a `peerDep` meaning users need to install the
package manually.

## Expected Behavior
As the package depends on `@rspack/core`, make sure it is set as a
dependency

## Related Issue(s)

Fixes #30307
This commit is contained in:
Colum Ferry 2025-03-27 13:18:37 +00:00 committed by GitHub
parent e08f3479e6
commit d12a4f4b12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/module-federation/package.json
View File

@ -30,15 +30,13 @@
"@nx/web": "file:../web",
"picocolors": "^1.1.0",
"webpack": "^5.88.0",
"@rspack/core": "^1.1.5",
"@module-federation/enhanced": "^0.9.0",
"@module-federation/node": "^2.6.26",
"@module-federation/sdk": "^0.9.0",
"express": "^4.21.2",
"http-proxy-middleware": "^3.0.3"
},
"peerDependencies": {
"@rspack/core": "^1.1.5"
},
"nx-migrations": {
"migrations": "./migrations.json"
},