From cfcedb481abe95db979f055e035e0240b13f1ff8 Mon Sep 17 00:00:00 2001 From: Nicholas Cunningham Date: Thu, 6 Jun 2024 08:42:32 -0600 Subject: [PATCH] fix(nextjs): enable failing storybook tests (#22675) --- .circleci/config.yml | 2 +- .nx/workflows/agents.yaml | 2 +- e2e/next/src/next-storybook.test.ts | 10 ++++------ 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 784e87af8f..ba498cd4d1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -94,7 +94,7 @@ jobs: - run: command: | sudo apt-get update - sudo apt-get install -y ca-certificates lsof + sudo apt-get install -y ca-certificates lsof libvips-dev libglib2.0-dev libgirepository1.0-dev - browser-tools/install-chrome - run-pnpm-install: os: linux diff --git a/.nx/workflows/agents.yaml b/.nx/workflows/agents.yaml index e9944845b8..2bbfbd1cff 100644 --- a/.nx/workflows/agents.yaml +++ b/.nx/workflows/agents.yaml @@ -25,7 +25,7 @@ launch-templates: - name: Install e2e deps script: | sudo apt-get update - sudo apt-get install -y ca-certificates lsof + sudo apt-get install -y ca-certificates lsof libvips-dev libglib2.0-dev libgirepository1.0-dev - name: Install Pnpm script: | npm install -g pnpm@8 diff --git a/e2e/next/src/next-storybook.test.ts b/e2e/next/src/next-storybook.test.ts index 866fe44535..5eef599acf 100644 --- a/e2e/next/src/next-storybook.test.ts +++ b/e2e/next/src/next-storybook.test.ts @@ -6,21 +6,19 @@ import { uniq, } from '@nx/e2e/utils'; -// TODO(katerina): Enable some time? -// This test fails because of sharp. In this PR I have included all related links to the issue. -xdescribe('Next.js Storybook', () => { +describe('Next.js Storybook', () => { const appName = uniq('app'); beforeAll(() => { newProject({ name: 'proj', packageManager: 'npm', - packages: ['@nx/next'], + packages: ['@nx/next', '@nx/react'], }); runCLI( `generate @nx/next:app ${appName} --e2eTestRunner=none --project-name-and-root-format=as-provided --no-interactive` ); runCLI( - `generate @nx/next:component Foo --directory=${appName}/components/foo/Foo.tsx --no-interactive` + `generate @nx/next:component foo --directory=${appName}/components/foo --nameAndDirectoryFormat=as-provided --no-interactive` ); }); @@ -28,7 +26,7 @@ xdescribe('Next.js Storybook', () => { it('should run a Next.js based Storybook setup', async () => { runCLI( - `generate @nx/next:storybook-configuration ${appName} --generateStories --no-interactive` + `generate @nx/react:storybook-configuration ${appName} --no-interactive` ); runCLI(`build-storybook ${appName}`); checkFilesExist(`${appName}/storybook-static/index.html`);