miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(web): remove unnecessary packages from being installed with @nrwl/web (#6554)

Browse Source
This commit is contained in:
Jack Hsu 2021-07-30 15:51:43 -04:00 committed by GitHub
parent e0a5dbf8d6
commit cdb954083e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dep-graph/dep-graph/src/test-setup.ts
View File

@ -1 +0,0 @@
import 'document-register-element';

4
package.json
View File

@ -129,7 +129,6 @@
"cz-conventional-changelog": "^3.0.2",
"cz-customizable": "^6.2.0",
"depcheck": "^1.3.1",
"document-register-element": "^1.13.1",
"dotenv": "~10.0.0",
"ejs": "^3.1.5",
"eslint": "7.10.0",
@ -263,7 +262,6 @@
"@testing-library/react-hooks": "^7.0.0",
"classnames": "^2.3.1",
"core-js": "^3.6.5",
"document-register-element": "^1.13.1",
"glob": "7.1.4",
"gray-matter": "^4.0.2",
"react": "17.0.2",
@ -281,4 +279,4 @@
"ng-packagr/rxjs": "6.6.7",
"**/xmlhttprequest-ssl": "~1.6.2"
}
}
}

1
packages/jest/src/generators/jest-project/files/src/test-setup.ts__tmpl__
View File

@ -1 +0,0 @@
<% if (setupFile === 'web-components') { %>import 'document-register-element';<% } %>

1
packages/web/src/generators/init/init.spec.ts
View File

@ -30,7 +30,6 @@ describe('init', () => {
expect(packageJson.devDependencies['@nrwl/web']).toBeDefined();
expect(packageJson.devDependencies[existing]).toBeDefined();
expect(packageJson.dependencies['@nrwl/web']).toBeUndefined();
expect(packageJson.dependencies['document-register-element']).toBeDefined();
expect(packageJson.dependencies[existing]).toBeDefined();
});

6
packages/web/src/generators/init/init.ts
View File

@ -10,10 +10,7 @@ import {
import { setDefaultCollection } from '@nrwl/workspace/src/utilities/set-default-collection';
import { runTasksInSerial } from '@nrwl/workspace/src/utilities/run-tasks-in-serial';
import { Schema } from './schema';
import {
documentRegisterElementVersion,
nxVersion,
} from '../../utils/versions';
import { nxVersion } from '../../utils/versions';
import { cypressInitGenerator } from '@nrwl/cypress';
import { jestInitGenerator } from '@nrwl/jest';
@ -27,7 +24,6 @@ function updateDependencies(tree: Tree) {
tree,
{
'core-js': '^3.6.5',
'document-register-element': documentRegisterElementVersion,
'regenerator-runtime': '0.13.7',
tslib: '^2.0.0',
},

2
packages/web/src/utils/versions.ts
View File

@ -1,2 +1,2 @@
export const nxVersion = '*';
export const documentRegisterElementVersion = '1.13.1';
export const coreJsVersion = '^3.16.0';

5
yarn.lock
View File

@ -11410,11 +11410,6 @@ doctrine@^3.0.0:
dependencies:
esutils "^2.0.2"
document-register-element@^1.13.1:
version "1.14.10"
resolved "https://registry.yarnpkg.com/document-register-element/-/document-register-element-1.14.10.tgz#a7bd025e6b73bd827fec2d8e90aba755e99387f5"
integrity sha512-w5UA37hEIrs+9pruo2yR5UD13c4UHDlkqqjt4qurnp7QsBI9b1IOi8WXUim+aCqKBsENX3Z/cso7XMOuwJH1Yw==
dom-accessibility-api@^0.5.4:
version "0.5.4"
resolved "https://registry.yarnpkg.com/dom-accessibility-api/-/dom-accessibility-api-0.5.4.tgz#b06d059cdd4a4ad9a79275f9d414a5c126241166"