miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(nextjs): fix next e2e test to ensure playwright installed (#29000)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Emily Xiong 2024-11-20 09:47:47 -08:00 committed by GitHub
parent 548973cd6c
commit b0a4f35afd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/next/src/next-playwright.test.ts
View File

@ -25,7 +25,7 @@ describe('Next Playwright e2e tests', () => {
afterAll(() => cleanupProject()); afterAll(() => cleanupProject());
it('should execute e2e tests using playwright', () => { it('should execute e2e tests using playwright', () => {
if (runE2ETests()) { if (runE2ETests('playwright')) {
const result = runCLI(`e2e ${appName}-e2e --verbose`); const result = runCLI(`e2e ${appName}-e2e --verbose`);
expect(result).toContain( expect(result).toContain(
`Successfully ran target e2e for project ${appName}-e2e` `Successfully ran target e2e for project ${appName}-e2e`
@ -53,7 +53,7 @@ describe('Next Playwright e2e tests', () => {
` `
); );
if (runE2ETests()) { if (runE2ETests('playwright')) {
const result = runCLI(`e2e ${appName}-e2e --verbose`); const result = runCLI(`e2e ${appName}-e2e --verbose`);
expect(result).toContain( expect(result).toContain(
`Successfully ran target e2e for project ${appName}-e2e` `Successfully ran target e2e for project ${appName}-e2e`