miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(nx-dev): show first tab if none selected (#27701)

Browse Source 
Tabs are not displaying correctly on the second page that is viewed.

Should be able to select the `project.json` tab on `Run Tasks` and then
switch to `Cache Task Results` and have the `Nx >= 17` tab shown.
This commit is contained in:
Isaac Mann 2024-08-29 13:16:17 -04:00 committed by GitHub
parent f95059917d
commit a7b2787069
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
nx-dev/ui-markdoc/src/lib/tags/tabs.component.tsx
View File

@ -23,14 +23,16 @@ export function Tabs({
const [currentTab, setCurrentTab] = useState<string>(labels[0]); const [currentTab, setCurrentTab] = useState<string>(labels[0]);
useEffect(() => { useEffect(() => {
const handleTabSelectedEvent = () => { const handleTabSelectedEvent = (defaultTab?: string) => {
const selectedTab = localStorage.getItem(SELECTED_TAB_KEY); const selectedTab = localStorage.getItem(SELECTED_TAB_KEY);
if (selectedTab && labels.includes(selectedTab)) { if (selectedTab && labels.includes(selectedTab)) {
setCurrentTab(selectedTab); setCurrentTab(selectedTab);
} else if (defaultTab) {
setCurrentTab(defaultTab);
} }
}; };
handleTabSelectedEvent(); handleTabSelectedEvent(labels[0]);
window.addEventListener(TAB_SELECTED_EVENT, handleTabSelectedEvent); window.addEventListener(TAB_SELECTED_EVENT, handleTabSelectedEvent);
return () => return () =>
window.removeEventListener(TAB_SELECTED_EVENT, handleTabSelectedEvent); window.removeEventListener(TAB_SELECTED_EVENT, handleTabSelectedEvent);