miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(js): workspace lib devDependencies should not be added to package.json (#17802)

Browse Source
This commit is contained in:
Adam Wootton 2023-09-06 15:13:11 -04:00 committed by GitHub
parent 2526967fc5
commit 9ba98f4b25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/js/src/utils/package-json/update-package-json.ts
View File

@ -144,8 +144,13 @@ function addMissingDependencies(
packageJson[propType][packageName] = version; packageJson[propType][packageName] = version;
} else { } else {
const packageName = entry.name; const packageName = entry.name;
if (!!workspacePackageJson.devDependencies?.[packageName]) {
return;
}
if ( if (
!packageJson.dependencies?.[packageName] && !packageJson.dependencies?.[packageName] &&
!packageJson.devDependencies?.[packageName] &&
!packageJson.peerDependencies?.[packageName] !packageJson.peerDependencies?.[packageName]
) { ) {
const outputs = getOutputsForTargetAndConfiguration( const outputs = getOutputsForTargetAndConfiguration(