fix(bundling): handle projects without targets in esbuild thirdParty migration (#16712)
This commit is contained in:
parent
e291c9c79b
commit
1e7aa39a9f
@ -14,6 +14,17 @@ describe('update-16-0-1-set-thirdparty-true', () => {
|
|||||||
tree = createTreeWithEmptyWorkspace();
|
tree = createTreeWithEmptyWorkspace();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('should skip migration targets are not set on the project', async () => {
|
||||||
|
addProjectConfiguration(tree, 'myapp', {
|
||||||
|
root: 'myapp',
|
||||||
|
});
|
||||||
|
await update(tree);
|
||||||
|
|
||||||
|
const config = readProjectConfiguration(tree, 'myapp');
|
||||||
|
|
||||||
|
expect(config.targets).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
it('should add thirdParty property if bundling is enabled implicitly', async () => {
|
it('should add thirdParty property if bundling is enabled implicitly', async () => {
|
||||||
addProjectConfiguration(tree, 'myapp', {
|
addProjectConfiguration(tree, 'myapp', {
|
||||||
root: 'myapp',
|
root: 'myapp',
|
||||||
@ -31,6 +42,7 @@ describe('update-16-0-1-set-thirdparty-true', () => {
|
|||||||
thirdParty: true,
|
thirdParty: true,
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should add thirdParty property if bundling is enabled explicitly', async () => {
|
it('should add thirdParty property if bundling is enabled explicitly', async () => {
|
||||||
addProjectConfiguration(tree, 'myapp', {
|
addProjectConfiguration(tree, 'myapp', {
|
||||||
root: 'myapp',
|
root: 'myapp',
|
||||||
@ -52,6 +64,7 @@ describe('update-16-0-1-set-thirdparty-true', () => {
|
|||||||
thirdParty: true,
|
thirdParty: true,
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should not add thirdParty property if bundling is disabled', async () => {
|
it('should not add thirdParty property if bundling is disabled', async () => {
|
||||||
addProjectConfiguration(tree, 'myapp', {
|
addProjectConfiguration(tree, 'myapp', {
|
||||||
root: 'myapp',
|
root: 'myapp',
|
||||||
@ -72,6 +85,7 @@ describe('update-16-0-1-set-thirdparty-true', () => {
|
|||||||
bundle: false,
|
bundle: false,
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should not set thirdParty property if it was already set', async () => {
|
it('should not set thirdParty property if it was already set', async () => {
|
||||||
addProjectConfiguration(tree, 'myapp', {
|
addProjectConfiguration(tree, 'myapp', {
|
||||||
root: 'myapp',
|
root: 'myapp',
|
||||||
|
|||||||
@ -10,6 +10,8 @@ export default async function update(host: Tree) {
|
|||||||
const projects = getProjects(host);
|
const projects = getProjects(host);
|
||||||
|
|
||||||
projects.forEach((projectConfig, projectName) => {
|
projects.forEach((projectConfig, projectName) => {
|
||||||
|
if (!projectConfig.targets) return;
|
||||||
|
|
||||||
let shouldUpdate = false;
|
let shouldUpdate = false;
|
||||||
|
|
||||||
Object.entries(projectConfig.targets).forEach(
|
Object.entries(projectConfig.targets).forEach(
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user