miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(js): append target when generating tmp tsconfig to prevent conflicts #21396 (#22671)

Browse Source
This commit is contained in:
Colum Ferry 2024-04-05 08:58:15 -07:00 committed by GitHub
parent 123932527a
commit 1c6118e140
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/vite/src/vite-legacy.test.ts
View File

@ -213,7 +213,7 @@ export default App;
const results = runCLI(`build ${app} --buildLibsFromSource=false`); const results = runCLI(`build ${app} --buildLibsFromSource=false`);
expect(results).toContain('Successfully ran target build for project'); expect(results).toContain('Successfully ran target build for project');
// this should be less modules than building from source // this should be less modules than building from source
expect(results).toContain('38 modules transformed'); expect(results).toContain('40 modules transformed');
}); });
it('should build app from libs without package.json in lib', () => { it('should build app from libs without package.json in lib', () => {

1
packages/js/src/utils/buildable-libs-utils.ts
View File

@ -434,6 +434,7 @@ export function createTmpTsConfig(
workspaceRoot, workspaceRoot,
'tmp', 'tmp',
projectRoot, projectRoot,
process.env.NX_TASK_TARGET_TARGET ?? 'build',
'tsconfig.generated.json' 'tsconfig.generated.json'
); );
const parsedTSConfig = readTsConfigWithRemappedPaths( const parsedTSConfig = readTsConfigWithRemappedPaths(