From 1891addc09b66919d3a41b0330459fd9f80f9fbb Mon Sep 17 00:00:00 2001 From: Colum Ferry Date: Fri, 23 Jun 2023 14:15:32 +0100 Subject: [PATCH] fix(react): mf should consider ssl when setting remote urls #16989 (#17746) --- packages/angular/src/utils/mf/utils.ts | 4 +++- packages/react/src/module-federation/utils.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/angular/src/utils/mf/utils.ts b/packages/angular/src/utils/mf/utils.ts index a1c4234ca3..db264241bd 100644 --- a/packages/angular/src/utils/mf/utils.ts +++ b/packages/angular/src/utils/mf/utils.ts @@ -58,7 +58,9 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) { ); } - const host = serveTarget.options?.host ?? 'http://localhost'; + const host = + serveTarget.options?.host ?? + `http${serveTarget.options.ssl ? 's' : ''}://localhost`; const port = serveTarget.options?.port ?? 4201; return `${ host.endsWith('/') ? host.slice(0, -1) : host diff --git a/packages/react/src/module-federation/utils.ts b/packages/react/src/module-federation/utils.ts index ba67d6684a..a5c8a9ae83 100644 --- a/packages/react/src/module-federation/utils.ts +++ b/packages/react/src/module-federation/utils.ts @@ -31,7 +31,9 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) { ); } - const host = serveTarget.options?.host ?? 'http://localhost'; + const host = + serveTarget.options?.host ?? + `http${serveTarget.options.ssl ? 's' : ''}://localhost`; const port = serveTarget.options?.port ?? 4201; return `${ host.endsWith('/') ? host.slice(0, -1) : host