From 0a4f682ef7d8df5f2b02ef5e0900a8a2ba19da90 Mon Sep 17 00:00:00 2001 From: Craigory Coppola Date: Fri, 2 May 2025 16:17:53 -0400 Subject: [PATCH] fix(core): tui summary should not show canceled during run-one because tasks are skipped (#31014) --- .../life-cycles/tui-summary-life-cycle.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/nx/src/tasks-runner/life-cycles/tui-summary-life-cycle.ts b/packages/nx/src/tasks-runner/life-cycles/tui-summary-life-cycle.ts index d6d4530524..425d84e622 100644 --- a/packages/nx/src/tasks-runner/life-cycles/tui-summary-life-cycle.ts +++ b/packages/nx/src/tasks-runner/life-cycles/tui-summary-life-cycle.ts @@ -167,7 +167,7 @@ export function getTuiTerminalSummaryLifeCycle({ ); } lines = [output.colors.green(lines.join(EOL))]; - } else if (totalCompletedTasks + stoppedTasks.size === totalTasks) { + } else if (inProgressTasks.size === 0) { let text = `Ran target ${output.bold( targets[0] )} for project ${output.bold(initiatingProject)}`; @@ -190,7 +190,7 @@ export function getTuiTerminalSummaryLifeCycle({ const viewLogs = viewLogsFooterRows(totalFailedTasks); - lines = [ + lines.push( output.colors.red( [ output.applyNxPrefix( @@ -209,11 +209,10 @@ export function getTuiTerminalSummaryLifeCycle({ )}`, ...viewLogs, ].join(EOL) - ), - ]; + ) + ); } else { - lines = [ - ...output.getVerticalSeparatorLines('red'), + lines.push( output.applyNxPrefix( 'red', output.colors.red( @@ -221,8 +220,8 @@ export function getTuiTerminalSummaryLifeCycle({ targets[0] )} for project ${output.bold(initiatingProject)}` ) + output.dim(` (${timeTakenText})`) - ), - ]; + ) + ); } // adds some vertical space after the summary to avoid bunching against terminal