cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

breaking: throw on missing dynamic import when import() is seen in systemjs (#12700)

Browse Source
This commit is contained in:
Huáng Jùnliàng
2021-01-29 13:14:13 -05:00
committed by GitHub
parent 3d69dc9471
commit f8fe8eaab1
7 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/babel-plugin-transform-modules-systemjs/src/index.js
View File

@@ -28,6 +28,12 @@ WARNING: Dynamic import() transformation must be enabled using the
no longer transform import() without using that plugin.
`;
const MISSING_PLUGIN_ERROR = `\
ERROR: Dynamic import() transformation must be enabled using the
@babel/plugin-proposal-dynamic-import plugin. Babel 8
no longer transforms import() without using that plugin.
`;
//todo: use getExportSpecifierName in `helper-module-transforms` when this library is refactored to NodePath usage.
export function getExportSpecifierName(
@@ -226,7 +232,11 @@ export default declare((api, options) => {
CallExpression(path, state: PluginState) {
if (t.isImport(path.node.callee)) {
if (!this.file.has("@babel/plugin-proposal-dynamic-import")) {
console.warn(MISSING_PLUGIN_WARNING);
if (process.env.BABEL_8_BREAKING) {
throw new Error(MISSING_PLUGIN_ERROR);
} else {
console.warn(MISSING_PLUGIN_WARNING);
}
}
path.replaceWith(