From d761d765bd26ee7cc376b41057511756d9cee8c7 Mon Sep 17 00:00:00 2001 From: Gustavo Rios de Sousa e Silva Date: Thu, 28 Dec 2017 19:17:28 +0000 Subject: [PATCH] Replace target: uglify tests with forceAllTransforms in preset-env --- .../{uglify => force-all-transforms}/actual.js | 0 .../{uglify => force-all-transforms}/expected.js | 0 .../{uglify => force-all-transforms}/options.json | 6 +++--- .../use-builtins-node-web/options.json | 6 +++--- .../preset-options/use-builtins-node/options.json | 6 +++--- packages/babel-preset-env/test/index.spec.js | 14 -------------- packages/babel-preset-env/test/utils.spec.js | 9 --------- 7 files changed, 9 insertions(+), 32 deletions(-) rename packages/babel-preset-env/test/fixtures/preset-options/{uglify => force-all-transforms}/actual.js (100%) rename packages/babel-preset-env/test/fixtures/preset-options/{uglify => force-all-transforms}/expected.js (100%) rename packages/babel-preset-env/test/fixtures/preset-options/{uglify => force-all-transforms}/options.json (56%) diff --git a/packages/babel-preset-env/test/fixtures/preset-options/uglify/actual.js b/packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/actual.js similarity index 100% rename from packages/babel-preset-env/test/fixtures/preset-options/uglify/actual.js rename to packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/actual.js diff --git a/packages/babel-preset-env/test/fixtures/preset-options/uglify/expected.js b/packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/expected.js similarity index 100% rename from packages/babel-preset-env/test/fixtures/preset-options/uglify/expected.js rename to packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/expected.js diff --git a/packages/babel-preset-env/test/fixtures/preset-options/uglify/options.json b/packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/options.json similarity index 56% rename from packages/babel-preset-env/test/fixtures/preset-options/uglify/options.json rename to packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/options.json index 63bd00a05c..60a4f26eaa 100644 --- a/packages/babel-preset-env/test/fixtures/preset-options/uglify/options.json +++ b/packages/babel-preset-env/test/fixtures/preset-options/force-all-transforms/options.json @@ -2,11 +2,11 @@ "presets": [ ["../../../../lib", { "targets": { - "chrome": 55, - "uglify": true + "chrome": 55 }, "modules": false, - "useBuiltIns": "entry" + "useBuiltIns": "entry", + "forceAllTransforms": true }] ] } diff --git a/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node-web/options.json b/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node-web/options.json index b478f84ee7..1d3af8c462 100644 --- a/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node-web/options.json +++ b/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node-web/options.json @@ -3,11 +3,11 @@ ["../../../../lib", { "targets": { "chrome": "55", - "node": "7.6", - "uglify": true + "node": "7.6" }, "modules": false, - "useBuiltIns": "entry" + "useBuiltIns": "entry", + "forceAllTransforms": true }] ] } diff --git a/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node/options.json b/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node/options.json index 002aaf86fc..339ba8f3a6 100644 --- a/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node/options.json +++ b/packages/babel-preset-env/test/fixtures/preset-options/use-builtins-node/options.json @@ -2,11 +2,11 @@ "presets": [ ["../../../../lib", { "targets": { - "node": "7.6", - "uglify": true + "node": "7.6" }, "modules": false, - "useBuiltIns": "entry" + "useBuiltIns": "entry", + "forceAllTransforms": true }] ] } diff --git a/packages/babel-preset-env/test/index.spec.js b/packages/babel-preset-env/test/index.spec.js index 0343775e1b..545199b47b 100644 --- a/packages/babel-preset-env/test/index.spec.js +++ b/packages/babel-preset-env/test/index.spec.js @@ -77,20 +77,6 @@ describe("babel-preset-env", () => { ); }); - it("returns true if uglify is specified as a target", () => { - const plugin = { - chrome: 50, - }; - const targets = { - chrome: "55.0.0", - uglify: true, - }; - assert.strictEqual( - babelPresetEnv.isPluginRequired(targets, plugin), - true, - ); - }); - it("returns when target is a decimal", () => { const plugin = { node: 6.9, diff --git a/packages/babel-preset-env/test/utils.spec.js b/packages/babel-preset-env/test/utils.spec.js index 9dbc454ae2..9443681573 100644 --- a/packages/babel-preset-env/test/utils.spec.js +++ b/packages/babel-preset-env/test/utils.spec.js @@ -31,15 +31,6 @@ describe("utils", () => { it("returns", () => { assert.deepStrictEqual(prettifyTargets({}), {}); - assert.deepStrictEqual( - prettifyTargets({ - uglify: true, - }), - { - uglify: true, - }, - ); - assert.deepStrictEqual( prettifyTargets({ chrome: "54.0.0",