From ca8556e36f584b7e694af27132a6bf8920083d52 Mon Sep 17 00:00:00 2001 From: Logan Smyth Date: Sun, 17 Apr 2016 15:11:12 -0700 Subject: [PATCH] Let function optimize better by using a boolean. --- packages/babel-generator/src/printer.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/babel-generator/src/printer.js b/packages/babel-generator/src/printer.js index d4c8e5e0da..6b24eeacc2 100644 --- a/packages/babel-generator/src/printer.js +++ b/packages/babel-generator/src/printer.js @@ -182,11 +182,11 @@ export default class Printer extends Buffer { } printTrailingComments(node, parent) { - this.printComments(this.getComments("trailingComments", node, parent)); + this.printComments(this.getComments(false, node, parent)); } printLeadingComments(node, parent) { - this.printComments(this.getComments("leadingComments", node, parent)); + this.printComments(this.getComments(true, node, parent)); } printInnerComments(node, indent = true) { @@ -250,8 +250,10 @@ export default class Printer extends Buffer { this.newline(lines); } - getComments(key, node) { - return (node && node[key]) || []; + getComments(leading, node) { + // Note, we use a boolean flag here instead of passing in the attribute name as it is faster + // because this is called extremely frequently. + return (node && (leading ? node.leadingComments : node.trailingComments)) || []; } shouldPrintComment(comment) {