cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix flow-comments - class type paramters and implements (#9897)

Browse Source
This commit is contained in:
Tan Li Hau 2019-04-27 04:23:13 +08:00 committed by Nicolò Ribaudo
parent 71013088ef
commit ca3c53ae0b
7 changed files with 36 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
packages/babel-plugin-transform-flow-comments/src/index.js
View File

@ -146,14 +146,31 @@ export default declare(api => {
Class(path) {
const { node } = path;
if (node.typeParameters) {
const typeParameters = path.get("typeParameters");
if (node.typeParameters || node.implements) {
const comments = [];
if (node.typeParameters) {
const typeParameters = path.get("typeParameters");
comments.push(
generateComment(typeParameters, typeParameters.node).replace(
/^:: /,
"",
),
);
typeParameters.remove();
}
if (node.implements) {
const impls = path.get("implements");
comments.push(
"implements " +
impls
.map(impl => generateComment(impl).replace(/^:: /, ""))
.join(", "),
);
delete node["implements"];
}
const block = path.get("body");
block.addComment(
"leading",
generateComment(typeParameters, typeParameters.node),
);
typeParameters.remove();
block.addComment("leading", ":: " + comments.join(" "));
}
},
},

1
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter-2/input.js vendored Normal file
View File

@ -0,0 +1 @@
class Foo implements Bar, Baz {}

3
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter-2/output.js vendored Normal file
View File

@ -0,0 +1,3 @@
class Foo
/*:: implements Bar, Baz*/
{}

1
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter-3/input.js vendored Normal file
View File

@ -0,0 +1 @@
class Foo<S, T> implements Bar, Baz {}

3
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter-3/output.js vendored Normal file
View File

@ -0,0 +1,3 @@
class Foo
/*:: <S, T> implements Bar, Baz*/
{}

1
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter/input.js vendored Normal file
View File

@ -0,0 +1 @@
class Foo<T> {}

3
packages/babel-plugin-transform-flow-comments/test/fixtures/flow-comments/class-type-parameter/output.js vendored Normal file
View File

@ -0,0 +1,3 @@
class Foo
/*:: <T>*/
{}