From c6c0bc07e2127d99a6ae9a594dbdae480aeedaca Mon Sep 17 00:00:00 2001 From: Sebastian McKenzie Date: Fri, 3 Apr 2015 04:39:39 +1100 Subject: [PATCH] fix empty whitelist in build-external-helpers - fixes #1129 --- src/babel/tools/build-external-helpers.js | 4 ++-- test/core/api.js | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/babel/tools/build-external-helpers.js b/src/babel/tools/build-external-helpers.js index 8f026258d8..4e3401af78 100644 --- a/src/babel/tools/build-external-helpers.js +++ b/src/babel/tools/build-external-helpers.js @@ -50,9 +50,9 @@ function buildVar(namespace, builder) { return t.program(body); } -function buildHelpers(body, namespace, whitelist = []) { +function buildHelpers(body, namespace, whitelist) { each(File.helpers, function (name) { - if (whitelist.length && whitelist.indexOf(name) === -1) return; + if (whitelist && whitelist.indexOf(name) === -1) return; var key = t.identifier(t.toIdentifier(name)); body.push(t.expressionStatement( diff --git a/test/core/api.js b/test/core/api.js index ca7c42ad15..b662cc1fe1 100644 --- a/test/core/api.js +++ b/test/core/api.js @@ -33,5 +33,11 @@ suite("api", function () { assert.ok(script.indexOf("classCallCheck") === -1); assert.ok(script.indexOf("inherits") >= 0); }); + + test("empty whitelist", function () { + var script = buildExternalHelpers([]); + assert.ok(script.indexOf("classCallCheck") === -1); + assert.ok(script.indexOf("inherits") === -1); + }); }); });