cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Support ConditionalExpressions in dry-error-messages rule (#11917)

Browse Source 
* Support ConditionalExpressions in dry-error-messages rule

* tests
This commit is contained in:
Brian Ng
2020-08-05 15:28:35 -05:00
committed by GitHub
parent 50b3262063
commit c0f6f0394d
5 changed files with 70 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-parser/src/parser/lval.js
View File

@@ -366,7 +366,6 @@ export default class LValParser extends NodeUtils {
? isStrictBindReservedWord(expr.name, this.inModule)
: isStrictBindOnlyReservedWord(expr.name))
) {
/* eslint-disable @babel/development-internal/dry-error-messages */
this.raise(
expr.start,
bindingType === BIND_NONE
@@ -374,7 +373,6 @@ export default class LValParser extends NodeUtils {
: Errors.StrictEvalArgumentsBinding,
expr.name,
);
/* eslint-enable @babel/development-internal/dry-error-messages */
}
if (checkClashes) {
@@ -471,7 +469,6 @@ export default class LValParser extends NodeUtils {
break;
default: {
/* eslint-disable @babel/development-internal/dry-error-messages */
this.raise(
expr.start,
bindingType === BIND_NONE
@@ -479,7 +476,6 @@ export default class LValParser extends NodeUtils {
: Errors.InvalidLhsBinding,
contextDescription,
);
/* eslint-enable @babel/development-internal/dry-error-messages */
}
}
}

2
packages/babel-parser/src/parser/statement.js
View File

@@ -2042,7 +2042,6 @@ export default class StatementParser extends ExpressionParser {
name: string,
): void {
if (this.state.exportedIdentifiers.indexOf(name) > -1) {
/* eslint-disable @babel/development-internal/dry-error-messages */
this.raise(
node.start,
name === "default"
@@ -2050,7 +2049,6 @@ export default class StatementParser extends ExpressionParser {
: Errors.DuplicateExport,
name,
);
/* eslint-enable @babel/development-internal/dry-error-messages */
}
this.state.exportedIdentifiers.push(name);
}