From cbd827b9db2c7c3a3a9400c3d149fbf732090e70 Mon Sep 17 00:00:00 2001 From: Diogo Franco Date: Fri, 11 Nov 2016 01:32:17 +0900 Subject: [PATCH 1/2] Rename ios_saf in browserslist data to ios, ignore unknown browsers browserslist queries, especially ones with percentages, often bring in mobile browsers that _probably_ have the similar support level as desktop ones, but since there's no support for them in the data, including them here would just lead to all plugins being enabled always. It's also easy to get crazy things like `op_mini` or `and_uc` in the results. Browserslist also reports iOS Safari as `ios_saf`, while the data uses `ios`, so it needs to be renamed. --- experimental/babel-preset-env/src/index.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/experimental/babel-preset-env/src/index.js b/experimental/babel-preset-env/src/index.js index e74357a256..10a2e96dbc 100644 --- a/experimental/babel-preset-env/src/index.js +++ b/experimental/babel-preset-env/src/index.js @@ -47,10 +47,21 @@ const isBrowsersQueryValid = (browsers) => { return typeof browsers === "string" || Array.isArray(browsers); }; +const browserNameMap = { + chrome: 'chrome', + edge: 'edge', + firefox: 'firefox', + ie: 'ie', + ios_saf: 'ios', + safari: 'safari' +} + const getLowestVersions = (browsers) => { return browsers.reduce((all, browser) => { const [browserName, browserVersion] = browser.split(" "); - all[browserName] = parseInt(browserVersion); + if (browserName in browserNameMap) { + all[browserNameMap[browserName]] = parseInt(browserVersion); + } return all; }, {}); }; From d407ddc00cbdef83433efee746cd8e11f4ed73cb Mon Sep 17 00:00:00 2001 From: Diogo Franco Date: Fri, 11 Nov 2016 01:43:21 +0900 Subject: [PATCH 2/2] Fix lint --- experimental/babel-preset-env/src/index.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/experimental/babel-preset-env/src/index.js b/experimental/babel-preset-env/src/index.js index 10a2e96dbc..304dcd9017 100644 --- a/experimental/babel-preset-env/src/index.js +++ b/experimental/babel-preset-env/src/index.js @@ -48,13 +48,13 @@ const isBrowsersQueryValid = (browsers) => { }; const browserNameMap = { - chrome: 'chrome', - edge: 'edge', - firefox: 'firefox', - ie: 'ie', - ios_saf: 'ios', - safari: 'safari' -} + chrome: "chrome", + edge: "edge", + firefox: "firefox", + ie: "ie", + ios_saf: "ios", + safari: "safari" +}; const getLowestVersions = (browsers) => { return browsers.reduce((all, browser) => {