cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Introduce scope tracking in the parser (#9493)

Browse Source 
* Introduce scope tracking

* Fix tests

* Add new tests

* Remove constructor-super check from transform as it is now in parser

* Correctly handle class properties and class scope

* Fix duplicate name check

* Convert scope identifier storage to array

* Enter a new scope in typescript module blocks

* Add test for duplicate declaration

* Rename error for duplicate exports

* Treat class declarations as lexical declaration

* Update whitelist

* Add tests

* Fix scope tracking for function declarations

* Migrate try-catch duplicate error

* Fix test

* More tests

* One more test

* Make scope a separate class and fix review comments

* Do not allow new.target in top scope arrow function

* Correctly enter new scope for declare module and treat type aliases as lexical declarations

* Tests for typescript scope tracking to not mark type aliases as duplicate

* Fix flow scope tracking

* Remove ident from test names as redundant

* Add test case for var and function

* Improve error messages

* Improve literal regex
This commit is contained in:
Daniel Tschinder
2019-02-25 11:04:52 -08:00
committed by GitHub
parent 918f149a63
commit a7391144b3
284 changed files with 5904 additions and 1842 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/babel-plugin-transform-classes/src/transformClass.js
View File

@@ -19,22 +19,6 @@ function buildConstructor(classRef, constructorBody, node) {
return func;
}
const verifyConstructorVisitor = traverse.visitors.merge([
environmentVisitor,
{
Super(path, state) {
if (state.isDerived) return;
const { node, parentPath } = path;
if (parentPath.isCallExpression({ callee: node })) {
throw path.buildCodeFrameError(
"super() is only allowed in a derived constructor",
);
}
},
},
]);
export default function transformClass(
path: NodePath,
file: any,
@@ -180,13 +164,6 @@ export default function transformClass(
if (t.isClassMethod(node)) {
const isConstructor = node.kind === "constructor";
if (isConstructor) {
path.traverse(verifyConstructorVisitor, {
isDerived: classState.isDerived,
file: classState.file,
});
}
const replaceSupers = new ReplaceSupers({
methodPath: path,
objectRef: classState.classRef,

5
packages/babel-plugin-transform-classes/test/fixtures/spec/super-call-only-allowed-in-derived-constructor/input.js vendored
View File

@@ -1,5 +0,0 @@
class Foo {
constructor() {
super();
}
}

4
packages/babel-plugin-transform-classes/test/fixtures/spec/super-call-only-allowed-in-derived-constructor/options.json vendored
View File

@@ -1,4 +0,0 @@
{
"throws": "super() is only allowed in a derived constructor",
"plugins": ["transform-classes"]
}

2
packages/babel-plugin-transform-classes/test/fixtures/spec/super-illegal-non-constructor-call/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "super() is only valid inside a class constructor. Make sure the method name is spelled exactly as 'constructor'."
"throws": "super() is only valid inside a class constructor of a subclass. Maybe a typo in the method name ('constructor') or not extending another class?"
}