class private methods and properties: should not allow spaces between # and identifier (#8756)

2018-10-02 23:31:06 -03:00
parent 36d12b5969
commit 850bc1d3dd
5 changed files with 28 additions and 0 deletions
--- a/packages/babel-parser/src/parser/expression.js
+++ b/packages/babel-parser/src/parser/expression.js
@@ -923,7 +923,19 @@ export default class ExpressionParser extends LValParser {
    if (isPrivate) {
      this.expectOnePlugin(["classPrivateProperties", "classPrivateMethods"]);
      const node = this.startNode();
+      const columnHashEnd = this.state.end;
      this.next();
+      const columnIdentifierStart = this.state.start;
+
+      const spacesBetweenHashAndIdentifier =
+        columnIdentifierStart - columnHashEnd;
+      if (spacesBetweenHashAndIdentifier != 0) {
+        this.raise(
+          columnIdentifierStart,
+          "Unexpected space between # and identifier",
+        );
+      }
+
      node.id = this.parseIdentifier(true);
      return this.finishNode(node, "PrivateName");
    } else {