@babel/eslint-parser: fix ImportExpression node to match ESTree spec (#10828)

* @babel/eslint-parser: fix ImportExpression node to match ESTree spec

* Update caller name for @babel/core.parseSync

* Move logic into estree plugin

* Add estree plugin tests

* Fix Flow error

* Fix flow

* Remove extra properties on ImportExpression node

* Incorporate review feedback

packages/babel-parser/src/parser/expression.js

@@ -758,7 +758,7 @@ export default class ExpressionParser extends LValParser {
   finishCallExpression<T: N.CallExpression | N.OptionalCallExpression>(
     node: T,
     optional: boolean,
-  ): T {
+  ): N.Expression {
     if (node.callee.type === "Import") {
       if (node.arguments.length !== 1) {
         this.raise(node.start, "import() requires exactly one argument");

packages/babel-parser/src/parser/lval.js

@@ -228,7 +228,7 @@ export default class LValParser extends NodeUtils {
   toReferencedListDeep(
     exprList: $ReadOnlyArray<?Expression>,
     isParenthesizedExpr?: boolean,
-  ): $ReadOnlyArray<?Expression> {
+  ): void {
     this.toReferencedList(exprList, isParenthesizedExpr);
 
     for (const expr of exprList) {
@@ -236,8 +236,6 @@ export default class LValParser extends NodeUtils {
         this.toReferencedListDeep(expr.elements);
       }
     }
-
-    return exprList;
   }
 
   // Parses spread element.

packages/babel-parser/src/plugins/estree.js

@@ -411,4 +411,32 @@ export default (superClass: Class<Parser>): Class<Parser> =>
         super.toAssignableObjectExpressionProp(prop, isBinding, isLast);
       }
     }
+
+    finishCallExpression<T: N.CallExpression | N.OptionalCallExpression>(
+      node: T,
+      optional: boolean,
+    ): N.Expression {
+      super.finishCallExpression(node, optional);
+
+      if (node.callee.type === "Import") {
+        ((node: N.Node): N.EstreeImportExpression).type = "ImportExpression";
+        ((node: N.Node): N.EstreeImportExpression).source = node.arguments[0];
+        delete node.arguments;
+        delete node.callee;
+      }
+
+      return node;
+    }
+
+    toReferencedListDeep(
+      exprList: $ReadOnlyArray<?N.Expression>,
+      isParenthesizedExpr?: boolean,
+    ): void {
+      // ImportExpressions do not have an arguments array.
+      if (!exprList) {
+        return;
+      }
+
+      super.toReferencedListDeep(exprList, isParenthesizedExpr);
+    }
   };

packages/babel-parser/src/types.js

@@ -1013,7 +1013,7 @@ export type FlowInterfaceType = NodeBase & {
   body: FlowObjectTypeAnnotation,
 };
 
-// estree
+// ESTree
 
 export type EstreeProperty = NodeBase & {
   type: "Property",
@@ -1039,6 +1039,11 @@ export type EstreeMethodDefinition = NodeBase & {
   variance?: ?FlowVariance,
 };
 
+export type EstreeImportExpression = NodeBase & {
+  type: "ImportExpression",
+  source: Expression,
+};
+
 // === === === ===
 // TypeScript
 // === === === ===