From 7acf4a46f0a7a301468fab2834d71e4d8227b071 Mon Sep 17 00:00:00 2001
From: Henry Zhu <hi@henryzoo.com>
Date: Thu, 13 Apr 2017 22:45:25 -0400
Subject: [PATCH] make useBuiltIns: false default, rename true to 'usage'
 (#285)

---
 experimental/babel-preset-env/src/index.js                | 2 +-
 experimental/babel-preset-env/src/normalize-options.js    | 8 ++++----
 .../test/debug-fixtures/versions-decimals/options.json    | 1 +
 .../test/debug-fixtures/versions-strings/options.json     | 1 +
 .../fixtures/dom-iterable/symbol-iterator-in/options.json | 2 +-
 .../fixtures/dom-iterable/symbol-iterator/options.json    | 2 +-
 .../fixtures/dom-iterable/yield-non-star/options.json     | 2 +-
 .../test/fixtures/dom-iterable/yield-star/options.json    | 2 +-
 .../options.json                                          | 2 +-
 .../builtins-used-instance-methods/options.json           | 2 +-
 .../builtins-used-native-support/options.json             | 2 +-
 .../builtins-used/options.json                            | 2 +-
 .../no-builtins-used/options.json                         | 2 +-
 .../regenerator-used-async-native-support/options.json    | 2 +-
 .../regenerator-used-async/options.json                   | 2 +-
 .../options.json                                          | 2 +-
 .../regenerator-used-generator/options.json               | 2 +-
 .../remove-babel-polyfill-import/options.json             | 2 +-
 .../test-modules-tranform/options.json                    | 2 +-
 .../preset-options/.use-builtins-all-exec/options.json    | 2 +-
 .../test/fixtures/preset-options/exclude/options.json     | 2 +-
 .../test/fixtures/preset-options/ios-6/options.json       | 2 +-
 .../fixtures/preset-options/no-transform/options.json     | 2 +-
 23 files changed, 26 insertions(+), 24 deletions(-)

diff --git a/experimental/babel-preset-env/src/index.js b/experimental/babel-preset-env/src/index.js
index 26a9650dc6..1025753f9d 100644
--- a/experimental/babel-preset-env/src/index.js
+++ b/experimental/babel-preset-env/src/index.js
@@ -168,7 +168,7 @@ export default function buildPreset(context, opts = {}) {
     console.log("");
   }
 
-  if (useBuiltIns === true) {
+  if (useBuiltIns === "usage") {
     plugins.push([
       addUsedBuiltInsPlugin,
       { polyfills: new Set(polyfills), regenerator, debug },
diff --git a/experimental/babel-preset-env/src/normalize-options.js b/experimental/babel-preset-env/src/normalize-options.js
index 0f3b755604..6463e49d2f 100644
--- a/experimental/babel-preset-env/src/normalize-options.js
+++ b/experimental/babel-preset-env/src/normalize-options.js
@@ -71,13 +71,13 @@ export const validateModulesOption = (modulesOpt = "commonjs") => {
   return modulesOpt;
 };
 
-export const validateUseBuiltInsOption = (builtInsOpt = true) => {
+export const validateUseBuiltInsOption = (builtInsOpt = false) => {
   invariant(
-    builtInsOpt === true || builtInsOpt === false || builtInsOpt === "entry",
+    builtInsOpt === "usage" || builtInsOpt === false || builtInsOpt === "entry",
     `Invalid Option: The 'useBuiltIns' option must be either
-    'false' to indicate no polyfill,
+    'false' (default) to indicate no polyfill,
     '"entry"' to indicate replacing the entry polyfill, or
-    'true' (default) to import only used polyfills per file`,
+    '"usage"' to import only used polyfills per file`,
   );
 
   return builtInsOpt;
diff --git a/experimental/babel-preset-env/test/debug-fixtures/versions-decimals/options.json b/experimental/babel-preset-env/test/debug-fixtures/versions-decimals/options.json
index 451949b4eb..0310aa5283 100644
--- a/experimental/babel-preset-env/test/debug-fixtures/versions-decimals/options.json
+++ b/experimental/babel-preset-env/test/debug-fixtures/versions-decimals/options.json
@@ -1,6 +1,7 @@
 {
   "presets": [
     ["../../lib", {
+      "useBuiltIns": "usage",
       "debug": true,
       "targets": {
         "chrome": 54,
diff --git a/experimental/babel-preset-env/test/debug-fixtures/versions-strings/options.json b/experimental/babel-preset-env/test/debug-fixtures/versions-strings/options.json
index 0954a3ae1b..5b040adc36 100644
--- a/experimental/babel-preset-env/test/debug-fixtures/versions-strings/options.json
+++ b/experimental/babel-preset-env/test/debug-fixtures/versions-strings/options.json
@@ -1,6 +1,7 @@
 {
   "presets": [
     ["../../lib", {
+      "useBuiltIns": "usage",
       "debug": true,
       "targets": {
         "chrome": "54",
diff --git a/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator-in/options.json b/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator-in/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator-in/options.json
+++ b/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator-in/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator/options.json b/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator/options.json
+++ b/experimental/babel-preset-env/test/fixtures/dom-iterable/symbol-iterator/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-non-star/options.json b/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-non-star/options.json
index 6a2de8474b..d87fce3e6a 100644
--- a/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-non-star/options.json
+++ b/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-non-star/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "targets": {
         "chrome": 55
       },
diff --git a/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-star/options.json b/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-star/options.json
index 6a2de8474b..d87fce3e6a 100644
--- a/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-star/options.json
+++ b/experimental/babel-preset-env/test/fixtures/dom-iterable/yield-star/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "targets": {
         "chrome": 55
       },
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods-native-support/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods-native-support/options.json
index 2bdb3e7756..e41e024eb2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods-native-support/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods-native-support/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false,
       "targets": {
         "chrome": 58
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-instance-methods/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-native-support/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-native-support/options.json
index 2bdb3e7756..e41e024eb2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-native-support/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used-native-support/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false,
       "targets": {
         "chrome": 58
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/builtins-used/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/no-builtins-used/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/no-builtins-used/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/no-builtins-used/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/no-builtins-used/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async-native-support/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async-native-support/options.json
index b27da48581..241b880ce4 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async-native-support/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async-native-support/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false,
       "targets": {
         "chrome": 55
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-async/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator-native-support/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator-native-support/options.json
index 6a7c844351..ec40d7f000 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator-native-support/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator-native-support/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false,
       "targets": {
         "node": 6
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/regenerator-used-generator/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json
index b6301eb2a2..fa0e9434e2 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "modules": false
     }]
   ]
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/test-modules-tranform/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/test-modules-tranform/options.json
index 9d6951bd70..18d3b5de7f 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/test-modules-tranform/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/test-modules-tranform/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true
+      "useBuiltIns": "usage"
     }]
   ]
 }
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options/.use-builtins-all-exec/options.json b/experimental/babel-preset-env/test/fixtures/preset-options/.use-builtins-all-exec/options.json
index 9d6951bd70..18d3b5de7f 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options/.use-builtins-all-exec/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options/.use-builtins-all-exec/options.json
@@ -1,7 +1,7 @@
 {
   "presets": [
     ["../../../../lib", {
-      "useBuiltIns": true
+      "useBuiltIns": "usage"
     }]
   ]
 }
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options/exclude/options.json b/experimental/babel-preset-env/test/fixtures/preset-options/exclude/options.json
index 72d58de065..7c6d3bfb0e 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options/exclude/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options/exclude/options.json
@@ -2,7 +2,7 @@
   "presets": [
     ["../../../../lib", {
       "modules": false,
-      "useBuiltIns": true,
+      "useBuiltIns": "usage",
       "exclude": [
         "transform-async-to-generator",
         "transform-regenerator"
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options/ios-6/options.json b/experimental/babel-preset-env/test/fixtures/preset-options/ios-6/options.json
index 9ff144ed41..38d936c33c 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options/ios-6/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options/ios-6/options.json
@@ -5,7 +5,7 @@
         "browsers": ["ios >= 6"]
       },
       "modules": false,
-      "useBuiltIns": true
+      "useBuiltIns": "usage"
     }]
   ]
 }
diff --git a/experimental/babel-preset-env/test/fixtures/preset-options/no-transform/options.json b/experimental/babel-preset-env/test/fixtures/preset-options/no-transform/options.json
index c35fc6979c..c8b43a8de0 100644
--- a/experimental/babel-preset-env/test/fixtures/preset-options/no-transform/options.json
+++ b/experimental/babel-preset-env/test/fixtures/preset-options/no-transform/options.json
@@ -5,7 +5,7 @@
         "chrome": "55"
       },
       "modules": false,
-      "useBuiltIns": true
+      "useBuiltIns": "usage"
     }]
   ]
 }