cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rephrase "assigning/binding to rvalue" errors to include context (#119) (#123)

Browse Source 
* Rephrase "assigning/binding to rvalue" error messages with context (#119)

* Fix code style in parser/lval.js

* istanbul ignore some unused branches in parser/lval.js

* Fix code style again in parser/lval.js
This commit is contained in:
Moti Zilberman
2016-09-22 19:02:20 +03:00
committed by Henry Zhu
parent 650e33376a
commit 774e6b446b
44 changed files with 87 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/parser/statement.js
View File

@@ -259,8 +259,9 @@ pp.parseForStatement = function (node) {
let refShorthandDefaultPos = {start: 0};
let init = this.parseExpression(true, refShorthandDefaultPos);
if (this.match(tt._in) || this.isContextual("of")) {
this.toAssignable(init);
this.checkLVal(init);
const description = this.isContextual("of") ? "for-of statement" : "for-in statement";
this.toAssignable(init, undefined, description);
this.checkLVal(init, undefined, undefined, description);
return this.parseForIn(node, init, forAwait);
} else if (refShorthandDefaultPos.start) {
this.unexpected(refShorthandDefaultPos.start);
@@ -371,7 +372,7 @@ pp.parseTryStatement = function (node) {
this.expect(tt.parenL);
clause.param = this.parseBindingAtom();
this.checkLVal(clause.param, true, Object.create(null));
this.checkLVal(clause.param, true, Object.create(null), "catch clause");
this.expect(tt.parenR);
clause.body = this.parseBlock();
@@ -564,7 +565,7 @@ pp.parseVar = function (node, isFor, kind) {
pp.parseVarHead = function (decl) {
decl.id = this.parseBindingAtom();
this.checkLVal(decl.id, true);
this.checkLVal(decl.id, true, undefined, "variable declaration");
};
// Parse a function declaration or literal (depending on the
@@ -1021,7 +1022,7 @@ pp.parseImportSpecifiers = function (node) {
this.next();
this.expectContextual("as");
specifier.local = this.parseIdentifier();
this.checkLVal(specifier.local, true);
this.checkLVal(specifier.local, true, undefined, "import namespace specifier");
node.specifiers.push(this.finishNode(specifier, "ImportNamespaceSpecifier"));
return;
}
@@ -1038,7 +1039,7 @@ pp.parseImportSpecifiers = function (node) {
let specifier = this.startNode();
specifier.imported = this.parseIdentifier(true);
specifier.local = this.eatContextual("as") ? this.parseIdentifier() : specifier.imported.__clone();
this.checkLVal(specifier.local, true);
this.checkLVal(specifier.local, true, undefined, "import specifier");
node.specifiers.push(this.finishNode(specifier, "ImportSpecifier"));
}
};
@@ -1046,6 +1047,6 @@ pp.parseImportSpecifiers = function (node) {
pp.parseImportSpecifierDefault = function (id, startPos, startLoc) {
let node = this.startNodeAt(startPos, startLoc);
node.local = id;
this.checkLVal(node.local, true);
this.checkLVal(node.local, true, undefined, "default import specifier");
return this.finishNode(node, "ImportDefaultSpecifier");
};