cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Show error if target version is not a number (#107)

Browse Source
This commit is contained in:
Brian Ng 2017-01-02 22:55:32 -06:00 committed by Henry Zhu
parent ec99493e53
commit 76e12a3cae
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
experimental/babel-preset-env/src/index.js
View File

@ -50,11 +50,12 @@ export const isPluginRequired = (supportedEnvironments, plugin) => {
const lowestImplementedVersion = plugin[environment];
const lowestTargetedVersion = supportedEnvironments[environment];
if (lowestTargetedVersion < lowestImplementedVersion) {
return true;
if (typeof lowestTargetedVersion === "string") {
throw new Error(`Target version must be a number,
'${lowestTargetedVersion}' was given for '${environment}'`);
}
return false;
return lowestTargetedVersion < lowestImplementedVersion;
});
return isRequiredForEnvironments.length > 0 ? true : false;

14
experimental/babel-preset-env/test/index.js
View File

@ -158,6 +158,20 @@ describe("babel-preset-env", () => {
babelPresetEnv.isPluginRequired(targets, plugin);
}, Error);
});
it("will throw if target version is not a number", () => {
const plugin = {
"node": 6,
};
const targets = {
"node": "6.5",
};
assert.throws(() => {
babelPresetEnv.isPluginRequired(targets, plugin);
}, Error);
});
});
describe("validateLooseOption", () => {