From 71b9f19e6a314da2ea7c128397a1ef708144f740 Mon Sep 17 00:00:00 2001 From: Ondrej Kraus Date: Mon, 2 Mar 2015 19:21:00 +0100 Subject: [PATCH] change to normal UMD (fixes bug with leaking variable in AMD mode) --- src/babel/build-external-helpers.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/babel/build-external-helpers.js b/src/babel/build-external-helpers.js index ab2d705b32..0db0f3be56 100644 --- a/src/babel/build-external-helpers.js +++ b/src/babel/build-external-helpers.js @@ -13,21 +13,15 @@ export default function (whitelist) { buildHelpers(body, namespace, whitelist); - var globalHelpersDeclar = t.variableDeclaration("var", [ - t.variableDeclarator( - namespace, - t.objectExpression({}) - ) - ]); var container = util.template("umd-commonjs-strict", { AMD_ARGUMENTS: t.arrayExpression([t.literal("exports")]), COMMON_ARGUMENTS: t.identifier("exports"), - BROWSER_ARGUMENTS: t.identifier("root"), - UMD_ROOT: namespace, + BROWSER_ARGUMENTS: t.assignmentExpression("=", t.memberExpression(t.identifier("root"), namespace), t.objectExpression({})), + UMD_ROOT: t.identifier("this"), FACTORY_PARAMETERS: t.identifier("global"), FACTORY_BODY: body }); - var tree = t.program([globalHelpersDeclar, container]); + var tree = t.program([container]); return generator(tree).code; };