cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

The { after a function generic type annotation is a statement (#578)

Browse Source 
This would have previously been interpreted as an expression,
because usually after ">" there can't be a statement.

Fixes #36
This commit is contained in:
Nicolò Ribaudo 2017-06-15 16:39:39 +02:00 committed by Brian Ng
parent 50ae16de38
commit 6b4fba4deb
3 changed files with 283 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/flow.js
View File

@ -958,6 +958,7 @@ export default (superClass: Class<Parser>): Class<Parser> => class extends super
this.state.inType = true;
const type = this.flowParseUnionType();
this.state.inType = oldInType;
this.state.exprAllowed = false;
return type;
}

1
test/fixtures/flow/type-annotations/function-expression-inside-jsx-attr/actual.js vendored Normal file
View File

@ -0,0 +1 @@
<bar x={function (x): Array<string> {}} />

281
test/fixtures/flow/type-annotations/function-expression-inside-jsx-attr/expected.json vendored Normal file
View File

@ -0,0 +1,281 @@
{
"type": "File",
"start": 0,
"end": 42,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 42
}
},
"program": {
"type": "Program",
"start": 0,
"end": 42,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 42
}
},
"sourceType": "module",
"body": [
{
"type": "ExpressionStatement",
"start": 0,
"end": 42,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 42
}
},
"expression": {
"type": "JSXElement",
"start": 0,
"end": 42,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 42
}
},
"openingElement": {
"type": "JSXOpeningElement",
"start": 0,
"end": 42,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 42
}
},
"attributes": [
{
"type": "JSXAttribute",
"start": 5,
"end": 39,
"loc": {
"start": {
"line": 1,
"column": 5
},
"end": {
"line": 1,
"column": 39
}
},
"name": {
"type": "JSXIdentifier",
"start": 5,
"end": 6,
"loc": {
"start": {
"line": 1,
"column": 5
},
"end": {
"line": 1,
"column": 6
}
},
"name": "x"
},
"value": {
"type": "JSXExpressionContainer",
"start": 7,
"end": 39,
"loc": {
"start": {
"line": 1,
"column": 7
},
"end": {
"line": 1,
"column": 39
}
},
"expression": {
"type": "FunctionExpression",
"start": 8,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 8
},
"end": {
"line": 1,
"column": 38
}
},
"id": null,
"generator": false,
"expression": false,
"async": false,
"params": [
{
"type": "Identifier",
"start": 18,
"end": 19,
"loc": {
"start": {
"line": 1,
"column": 18
},
"end": {
"line": 1,
"column": 19
},
"identifierName": "x"
},
"name": "x"
}
],
"predicate": null,
"returnType": {
"type": "TypeAnnotation",
"start": 20,
"end": 35,
"loc": {
"start": {
"line": 1,
"column": 20
},
"end": {
"line": 1,
"column": 35
}
},
"typeAnnotation": {
"type": "GenericTypeAnnotation",
"start": 22,
"end": 35,
"loc": {
"start": {
"line": 1,
"column": 22
},
"end": {
"line": 1,
"column": 35
}
},
"typeParameters": {
"type": "TypeParameterInstantiation",
"start": 27,
"end": 35,
"loc": {
"start": {
"line": 1,
"column": 27
},
"end": {
"line": 1,
"column": 35
}
},
"params": [
{
"type": "StringTypeAnnotation",
"start": 28,
"end": 34,
"loc": {
"start": {
"line": 1,
"column": 28
},
"end": {
"line": 1,
"column": 34
}
}
}
]
},
"id": {
"type": "Identifier",
"start": 22,
"end": 27,
"loc": {
"start": {
"line": 1,
"column": 22
},
"end": {
"line": 1,
"column": 27
},
"identifierName": "Array"
},
"name": "Array"
}
}
},
"body": {
"type": "BlockStatement",
"start": 36,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 36
},
"end": {
"line": 1,
"column": 38
}
},
"body": [],
"directives": []
}
}
}
}
],
"name": {
"type": "JSXIdentifier",
"start": 1,
"end": 4,
"loc": {
"start": {
"line": 1,
"column": 1
},
"end": {
"line": 1,
"column": 4
}
},
"name": "bar"
},
"selfClosing": true
},
"closingElement": null,
"children": []
}
}
],
"directives": []
}
}