cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix parsing of private fields (#566)

Browse Source 
The computed key is not part of the spec.
key for ClassProperties is an Expression
Do not parse computed and literal keys for PrivateClassProperties
This commit is contained in:
Daniel Tschinder
2017-06-06 17:42:07 +02:00
committed by Henry Zhu
parent 37793d5be7
commit 69cba43f82
18 changed files with 38 additions and 1919 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/parser/statement.js
View File

@@ -642,9 +642,7 @@ export default class StatementParser extends ExpressionParser {
isNonstaticConstructor(method: N.ClassMethod | N.ClassProperty): boolean {
return !method.computed && !method.static && (
// $FlowFixMe ('key' downcasting)
(method.key.name === "constructor") || // Identifier
// $FlowFixMe ('key' downcasting)
(method.key.value === "constructor") // Literal
);
}
@@ -707,7 +705,7 @@ export default class StatementParser extends ExpressionParser {
if (this.hasPlugin("classPrivateProperties") && this.match(tt.hash)) { // Private property
this.next();
const privateProp: N.ClassPrivateProperty = memberAny;
this.parsePropertyName(privateProp);
privateProp.key = this.parseIdentifier(true);
classBody.body.push(this.parsePrivateClassProperty(privateProp));
return;
}
@@ -749,7 +747,6 @@ export default class StatementParser extends ExpressionParser {
const isSimple = this.match(tt.name);
const key = this.parsePropertyName(methodOrProp);
// $FlowFixMe ('key' downcasting)
if (!methodOrProp.computed && methodOrProp.static && (methodOrProp.key.name === "prototype" || methodOrProp.key.value === "prototype")) {
this.raise(methodOrProp.key.start, "Classes may not have static property named prototype");
}