cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

unshiftContainer seems to incorrectly handle function params #6150 (#6354)

Browse Source
This commit is contained in:
Abhilash Singh 2017-09-30 18:44:51 +05:30 committed by Henry Zhu
parent 7c8a6cb461
commit 6230855b71
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-traverse/src/path/modification.js
View File

@ -20,7 +20,9 @@ export function insertBefore(nodes) {
) {
return this.parentPath.insertBefore(nodes);
} else if (
(this.isNodeType("Expression") && this.listKey !== "params") ||
(this.isNodeType("Expression") &&
this.listKey !== "params" &&
this.listKey !== "arguments") ||
(this.parentPath.isForStatement() && this.key === "init")
) {
if (this.node) nodes.push(this.node);

13
packages/babel-traverse/test/modification.js
View File

@ -53,6 +53,19 @@ describe("modification", function() {
assert.equal(generateCode(rootPath), "function test(a) {\n b;\n}");
});
it("properly handles more than one arguments", function() {
const code = "foo(a, b);";
const ast = parse(code);
traverse(ast, {
CallExpression: function(path) {
path.unshiftContainer("arguments", t.identifier("d"));
assert.equal(generateCode(path), "foo(d, a, b);");
path.unshiftContainer("arguments", t.stringLiteral("s"));
assert.equal(generateCode(path), `foo("s", d, a, b);`);
},
});
});
});
describe("insertBefore", function() {