cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix: preserve shadowed for-loop declarators (#11242)

Browse Source 
* fix: do not remove for-loop declarators

* fix: do not remove uninitialized var declarators in for init
This commit is contained in:
Huáng Jùnliàng
2020-03-12 14:07:59 -04:00
committed by GitHub
parent dadd22e161
commit 565ab9a3fc
10 changed files with 56 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/babel-plugin-transform-parameters/src/params.js
View File

@@ -76,11 +76,19 @@ export default function convertFunctionParams(path, loose) {
switch (node.type) {
case "VariableDeclarator":
if (node.init === null) {
redeclarator.remove();
} else {
state.iife = true;
const declaration = redeclarator.parentPath;
// The following uninitialized var declarators should not be removed
// for (var x in {})
// for (var x;;)
if (
!declaration.parentPath.isFor() ||
declaration.parentPath.get("body") === declaration
) {
redeclarator.remove();
break;
}
}
break;
// fall through
case "FunctionDeclaration":
state.iife = true;
break;