From 5248f499b3c97fe4021e4bac848e7f2024639901 Mon Sep 17 00:00:00 2001 From: Henry Zhu Date: Fri, 7 Apr 2017 17:47:43 -0400 Subject: [PATCH] check if import/required babel-polyfill are removed --- experimental/babel-preset-env/src/use-built-ins-plugin.js | 4 +--- .../remove-babel-polyfill-import/actual.js | 4 ++++ .../remove-babel-polyfill-import/expected.js | 0 .../remove-babel-polyfill-import/options.json | 8 ++++++++ 4 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/actual.js create mode 100644 experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/expected.js create mode 100644 experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json diff --git a/experimental/babel-preset-env/src/use-built-ins-plugin.js b/experimental/babel-preset-env/src/use-built-ins-plugin.js index 0fa4f4c04e..21e57f7074 100644 --- a/experimental/babel-preset-env/src/use-built-ins-plugin.js +++ b/experimental/babel-preset-env/src/use-built-ins-plugin.js @@ -20,8 +20,6 @@ function getObjectString(node) { return node.name; } else if (node.type === "MemberExpression") { return `${getObjectString(node.object)}.${getObjectString(node.property)}`; - } else { - return ""; } } @@ -94,7 +92,7 @@ When setting "useBuiltIns: true", polyfills are automatically imported when need Please remove the "require('babel-polyfill')" call or use "useBuiltIns: 'entry'" instead. `, ); - path.remove(); + bodyPath.remove(); } }); }, diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/actual.js b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/actual.js new file mode 100644 index 0000000000..a62d650218 --- /dev/null +++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/actual.js @@ -0,0 +1,4 @@ +import "babel-polyfill"; +import "babel-polyfill"; +require("babel-polyfill"); +require("babel-polyfill"); diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/expected.js b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/expected.js new file mode 100644 index 0000000000..e69de29bb2 diff --git a/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json new file mode 100644 index 0000000000..b6301eb2a2 --- /dev/null +++ b/experimental/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/remove-babel-polyfill-import/options.json @@ -0,0 +1,8 @@ +{ + "presets": [ + ["../../../../lib", { + "useBuiltIns": true, + "modules": false + }] + ] +}