cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #3170 from babel/fix-numeric-member-expr

Browse Source 
Fix invalid codegen for number member expr
This commit is contained in:
Amjad Masad 2015-12-16 12:21:42 -08:00
commit 4bb7dbabb0
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/babel-generator/src/generators/expressions.js
View File

@ -221,14 +221,8 @@ export function MemberExpression(node: Object) {
this.print(node.property, node);
this.push("]");
} else {
if (t.isLiteral(node.object) && !t.isTemplateLiteral(node.object)) {
let val;
if (this.format.minified) {
val = this._stringLiteral(node.object);
} else {
val = this.getPossibleRaw(node.object) || this._stringLiteral(node.object);
}
if (t.isNumericLiteral(node.object)) {
let val = this.getPossibleRaw(node.object) || node.object.value;
if (isInteger(+val) && !SCIENTIFIC_NOTATION.test(val) && !ZERO_DECIMAL_INTEGER.test(val) && !this.endsWith(".")) {
this.push(".");
}

6
packages/babel-generator/test/index.js
View File

@ -16,6 +16,12 @@ suite("generation", function () {
assert.ok(t.VISITOR_KEYS[type], type + " should not exist");
});
});
test("valid code", function() {
// Should not generate `0.foo`
var mem = t.memberExpression(t.numericLiteral(60702), t.identifier("foo"));
new Function(generate.default(mem).code);
});
});
var suites = require("babel-helper-fixtures").default(__dirname + "/fixtures");