From e0f1bd76cbe17096203a568e697319e2671ee191 Mon Sep 17 00:00:00 2001 From: phantom10111 Date: Sat, 7 Nov 2015 23:08:38 +0100 Subject: [PATCH 1/2] Fix clearNode clearing all properties instead of just symbols --- packages/babel-traverse/src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-traverse/src/index.js b/packages/babel-traverse/src/index.js index 28dfdd1ac0..60b83915c9 100644 --- a/packages/babel-traverse/src/index.js +++ b/packages/babel-traverse/src/index.js @@ -87,7 +87,7 @@ traverse.clearNode = function (node) { if (key[0] === "_" && node[key] != null) node[key] = undefined; } - let syms: Array = Object.getOwnPropertyNames(node); + let syms: Array = Object.getOwnPropertySymbols(node); for (let sym of syms) { node[sym] = null; } From 22dc8f8323ff2de9f4837d1afcfc29f752c4e926 Mon Sep 17 00:00:00 2001 From: phantom10111 Date: Sat, 7 Nov 2015 23:09:00 +0100 Subject: [PATCH 2/2] Fix scope cache returning an item that was just inserted --- packages/babel-traverse/src/scope/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/babel-traverse/src/scope/index.js b/packages/babel-traverse/src/scope/index.js index d31dcea851..a9dd28382d 100644 --- a/packages/babel-traverse/src/scope/index.js +++ b/packages/babel-traverse/src/scope/index.js @@ -33,7 +33,8 @@ function getCache(node, parentScope, self) { } } else if (!node[CACHE_MULTIPLE_KEY]) { // no scope has ever been associated with this node - return node[CACHE_SINGLE_KEY] = self; + node[CACHE_SINGLE_KEY] = self; + return; } // looks like we have either a single scope association that was never matched or