cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Optimize parseBindingAtom code to get better error messages (#9762)

Browse Source
This commit is contained in:
Daniel Tschinder 2019-03-25 14:23:39 -07:00 committed by GitHub
parent d720c6cfff
commit 444daf9224
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
20 changed files with 13 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/babel-parser/src/parser/lval.js
View File

@ -231,9 +231,6 @@ export default class LValParser extends NodeUtils {
// Parses lvalue (assignable) atom.
parseBindingAtom(): Pattern {
switch (this.state.type) {
case tt.name:
return this.parseIdentifier();
case tt.bracketL: {
const node = this.startNode();
this.next();
@ -243,10 +240,9 @@ export default class LValParser extends NodeUtils {
case tt.braceL:
return this.parseObj(true);
default:
throw this.unexpected();
}
return this.parseIdentifier();
}
parseBindingList(

2
packages/babel-parser/test/fixtures/core/uncategorised/382/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'if' (1:4)"
}

2
packages/babel-parser/test/fixtures/core/uncategorised/397/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:11)"
"throws": "Unexpected keyword 'if' (1:11)"
}

2
packages/babel-parser/test/fixtures/core/uncategorised/398/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:11)"
"throws": "Unexpected keyword 'true' (1:11)"
}

2
packages/babel-parser/test/fixtures/core/uncategorised/399/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:11)"
"throws": "Unexpected keyword 'false' (1:11)"
}

2
packages/babel-parser/test/fixtures/core/uncategorised/400/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:11)"
"throws": "Unexpected keyword 'null' (1:11)"
}

2
packages/babel-parser/test/fixtures/core/uncategorised/523/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'this' (1:4)"
}

2
packages/babel-parser/test/fixtures/es2015/uncategorised/229/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'super' (1:4)"
}

2
packages/babel-parser/test/fixtures/es2015/uncategorised/230/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'default' (1:4)"
}

2
packages/babel-parser/test/fixtures/es2015/uncategorised/231/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'default' (1:4)"
}

2
packages/babel-parser/test/fixtures/es2015/uncategorised/232/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:6)"
"throws": "Unexpected keyword 'default' (1:6)"
}

2
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0064/options.json vendored
View File

@ -1,3 +1,3 @@
{
"throws": "Unexpected token (1:4)"
"throws": "Unexpected keyword 'if' (1:4)"
}

1
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0104/input.js vendored
View File

@ -1 +0,0 @@
function t(if) { }

3
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0104/options.json vendored
View File

@ -1,3 +0,0 @@
{
"throws": "Unexpected token (1:11)"
}

1
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0105/input.js vendored
View File

@ -1 +0,0 @@
function t(true) { }

3
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0105/options.json vendored
View File

@ -1,3 +0,0 @@
{
"throws": "Unexpected token (1:11)"
}

1
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0106/input.js vendored
View File

@ -1 +0,0 @@
function t(false) { }

3
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0106/options.json vendored
View File

@ -1,3 +0,0 @@
{
"throws": "Unexpected token (1:11)"
}

1
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0107/input.js vendored
View File

@ -1 +0,0 @@
function t(null) { }

3
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0107/options.json vendored
View File

@ -1,3 +0,0 @@
{
"throws": "Unexpected token (1:11)"
}