cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove grouped type arrow restriction as it seems flow no longer has it - fixes #44

Browse Source
This commit is contained in:
Sebastian McKenzie 2016-06-22 13:43:32 +01:00
parent f63802c716
commit 3524ad510f
3 changed files with 261 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/flow.js
View File

@ -517,20 +517,6 @@ pp.flowParsePrimaryType = function () {
if (isGroupedType) {
type = this.flowParseType();
this.expect(tt.parenR);
// If we see a => next then someone was probably confused about
// function types, so we can provide a better error message
if (this.eat(tt.arrow)) {
this.raise(node,
"Unexpected token =>. It looks like " +
"you are trying to write a function type, but you ended up " +
"writing a grouped type followed by an =>, which is a syntax " +
"error. Remember, function type parameters are named so function " +
"types look like (name1: type1, name2: type2) => returnType. You " +
"probably wrote (type1) => returnType"
);
}
return type;
}

1
test/fixtures/flow/type-annotations/existential-type-param-2/actual.js vendored Normal file
View File

@ -0,0 +1 @@
let f : * = (x : null | *) : (*) => {}

260
test/fixtures/flow/type-annotations/existential-type-param-2/expected.json vendored Normal file
View File

@ -0,0 +1,260 @@
{
"type": "File",
"start": 0,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 38
}
},
"program": {
"type": "Program",
"start": 0,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 38
}
},
"sourceType": "module",
"body": [
{
"type": "VariableDeclaration",
"start": 0,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 38
}
},
"declarations": [
{
"type": "VariableDeclarator",
"start": 4,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 4
},
"end": {
"line": 1,
"column": 38
}
},
"id": {
"type": "Identifier",
"start": 4,
"end": 9,
"loc": {
"start": {
"line": 1,
"column": 4
},
"end": {
"line": 1,
"column": 9
}
},
"name": "f",
"typeAnnotation": {
"type": "TypeAnnotation",
"start": 6,
"end": 9,
"loc": {
"start": {
"line": 1,
"column": 6
},
"end": {
"line": 1,
"column": 9
}
},
"typeAnnotation": {
"type": "ExistentialTypeParam",
"start": 8,
"end": 9,
"loc": {
"start": {
"line": 1,
"column": 8
},
"end": {
"line": 1,
"column": 9
}
}
}
}
},
"init": {
"type": "ArrowFunctionExpression",
"start": 12,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 12
},
"end": {
"line": 1,
"column": 38
}
},
"returnType": {
"type": "TypeAnnotation",
"start": 27,
"end": 32,
"loc": {
"start": {
"line": 1,
"column": 27
},
"end": {
"line": 1,
"column": 32
}
},
"typeAnnotation": {
"type": "ExistentialTypeParam",
"start": 30,
"end": 31,
"loc": {
"start": {
"line": 1,
"column": 30
},
"end": {
"line": 1,
"column": 31
}
}
}
},
"id": null,
"generator": false,
"expression": false,
"async": false,
"params": [
{
"type": "Identifier",
"start": 13,
"end": 14,
"loc": {
"start": {
"line": 1,
"column": 13
},
"end": {
"line": 1,
"column": 14
}
},
"name": "x",
"typeAnnotation": {
"type": "TypeAnnotation",
"start": 15,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 15
},
"end": {
"line": 1,
"column": 25
}
},
"typeAnnotation": {
"type": "UnionTypeAnnotation",
"start": 17,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 17
},
"end": {
"line": 1,
"column": 25
}
},
"types": [
{
"type": "NullLiteralTypeAnnotation",
"start": 17,
"end": 21,
"loc": {
"start": {
"line": 1,
"column": 17
},
"end": {
"line": 1,
"column": 21
}
},
"value": true
},
{
"type": "ExistentialTypeParam",
"start": 24,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 24
},
"end": {
"line": 1,
"column": 25
}
}
}
]
}
}
}
],
"body": {
"type": "BlockStatement",
"start": 36,
"end": 38,
"loc": {
"start": {
"line": 1,
"column": 36
},
"end": {
"line": 1,
"column": 38
}
},
"body": [],
"directives": []
}
}
}
],
"kind": "let"
}
],
"directives": []
}
}