cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

handle TCO for calls that exceed the functions parameter count - fixes #1589

Browse Source
This commit is contained in:
Sebastian McKenzie
2015-05-21 01:21:49 +01:00
parent f2f6bbb02c
commit 348c0d2542
3 changed files with 51 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/babel/transformation/transformers/es6/tail-call.js
View File

@@ -51,7 +51,7 @@ var visitor = {
},
ReferencedIdentifier(node, parent, scope, state) {
if (node.name === "arguments" && !state.isShadowed) {
if (node.name === "arguments" && (!state.isShadowed || node._shadowedFunctionLiteral)) {
state.needsArguments = true;
state.argumentsPaths.push(this);
}
@@ -211,6 +211,7 @@ class TailCallTransformer {
var decl = t.variableDeclarator(this.argumentsId);
if (this.argumentsId) {
decl.init = t.identifier("arguments");
decl.init._shadowedFunctionLiteral = true;
}
topVars.push(decl);
}
@@ -291,7 +292,8 @@ class TailCallTransformer {
}
subTransformCallExpression(node) {
var callee = node.callee, thisBinding, args;
var callee = node.callee;
var thisBinding, args;
if (t.isMemberExpression(callee, { computed: false }) && t.isIdentifier(callee.property)) {
switch (callee.property.name) {
@@ -301,6 +303,7 @@ class TailCallTransformer {
case "apply":
args = node.arguments[1] || t.identifier("undefined");
this.needsArguments = true;
break;
default:
@@ -334,6 +337,10 @@ class TailCallTransformer {
args = t.arrayExpression(node.arguments);
}
if (t.isArrayExpression(args) && args.elements.length > this.node.params.length) {
this.needsArguments = true;
}
var argumentsId = this.getArgumentsId();
var params = this.getParams();