cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update to core-js@3 (#7646)

Browse Source 
### `@babel/runtime`
- Added `@babel/runtime-corejs3` package and `corejs: 3` options to `@babel/plugin-transform-runtime`.
- Added support of instance methods, fixes #8928.
- Added flag `proposals` (in `corejs: { version: 3, proposals: true }` format) for support all proposals polyfills from `core-js`.
- Used separate directories in runtime for `core-js` entry points with proposals and without.
- Used `get-iterator-method` helper for getting iterators, fixes #2500.
- As a cheap bonus, added support of IE8- (except some cases of `regenerator`).

### `@babel/polyfill`
- Should be deprecated in favor of separate usage required features from `core-js` and `regenerator-runtime` with an informative message.

### `@babel/preset-env`
- Uses for built-ins data from [`core-js-compat`](https://github.com/zloirock/core-js/tree/master/packages/core-js-compat) instead of `compat-table` since information from `compat-table` [is not enough](https://github.com/zloirock/core-js/tree/master/packages/core-js-compat).
- `useBuilIns` now requires direct setting of `corejs` version option, without it will be used `2` by default and shown deprecation warning.
- Added support of minor `core-js` versions for simplify updating in the future.
- For preventing some order-related problems, polyfills in the both `core-js@3` plugins added on `post` stage in the order of `core-js-compat` data.
- Divided plugins and polyfills parts of `preset-env`, instead of 2 internal plugins for adding polyfills, we have 6: usage and entry versions of plugins for `core-js@2`, ### Current state:
`core-js@3`, `regenerator-runtime`.
- Added support `samsung` target (for Samsung Internet) since `core-js-compat` and `compat-table` now contains mapping for this, fixes #6602.

#### `useBuilIns: entry` with `corejs: 3`
- No longer transforms `@babel/polyfill`.
- Transforms **all possible** `core-js` entry points to import of related modules (based on data from [`core-js-compat`](https://unpkg.com/core-js-compat@3.0.0-beta.15/entries.json)).
- Since of this, we no longer need `shippedProposals` / `proposals` flags with `useBuilIns: entry`.
- Removes `regenerator-runtime/runtime` import where it's not required.

#### `useBuilIns: usage` with `corejs: 3`
- In addition to `shippedProposals`, added flag `proposals`  (in `corejs: { version: 3, proposals: true }` format) for polyfill all proposals from `core-js`.
- Fixed list of dependencies in built-in definitions.
- Improved the way of determination method / built-in name and source of this method.
- Adds import of required polyfills on `MemberExpression`, `ObjectPattern`, `in` operator.
- Adds import of required polyfills on access to global object properties.
- Adds import of all required common iterators on all syntax features which use iterators protocol (`for-of`, destructuring, spread, `yield` delegation, etc.).
- Adds import of promises on syntax features which use promises (async functions/generators, dynamic import, etc.), fixes #9250, #7402, etc.

### `core-js@2` stuff
I didn't want to tough `core-js@2`-related stuff, however
- Fixed some serious errors in definitions which breaks `Object.getOwnPropertySymbols`, `Symbol.toStringTag` logic, `Promise#finally`, `Array#forEach`, etc.
- `Array#flatMap` and trim methods moved to stable features as a part of ES2019 and loaded by deprecated `@babel/polyfill` and `@babel/preset-env` with `corejs: 2` option.
This commit is contained in:
Denis Pushkarev
2019-03-20 03:07:45 +07:00
committed by Nicolò Ribaudo
parent 7df0d16131
commit 3303b079c5
889 changed files with 18536 additions and 1575 deletions
Download Patch File Download Diff File Expand all files Collapse all files

227
packages/babel-plugin-transform-runtime/src/index.js
View File

@@ -4,7 +4,8 @@ import { declare } from "@babel/helper-plugin-utils";
import { addDefault, isModule } from "@babel/helper-module-imports";
import { types as t } from "@babel/core";
import getDefinitions from "./definitions";
import getCoreJS2Definitions from "./runtime-corejs2-definitions";
import getCoreJS3Definitions from "./runtime-corejs3-definitions";
function resolveAbsoluteRuntime(moduleName: string, dirname: string) {
try {
@@ -33,7 +34,7 @@ export default declare((api, options, dirname) => {
api.assertVersion(7);
const {
corejs: corejsVersion = false,
corejs,
helpers: useRuntimeHelpers = true,
regenerator: useRuntimeRegenerator = true,
useESModules = false,
@@ -41,21 +42,48 @@ export default declare((api, options, dirname) => {
absoluteRuntime = false,
} = options;
const definitions = getDefinitions(runtimeVersion);
let proposals = false;
let rawVersion;
if (typeof corejs === "object" && corejs !== null) {
rawVersion = corejs.version;
proposals = Boolean(corejs.proposals);
} else {
rawVersion = corejs;
}
const corejsVersion = rawVersion ? Number(rawVersion) : false;
if (![false, 2, 3].includes(corejsVersion)) {
throw new Error(
`The \`core-js\` version must be false, 2 or 3, but got ${JSON.stringify(
rawVersion,
)}.`,
);
}
if (proposals && (!corejsVersion || corejsVersion < 3)) {
throw new Error(
"The 'proposals' option is only supported when using 'corejs: 3'",
);
}
if (typeof useRuntimeRegenerator !== "boolean") {
throw new Error(
"The 'regenerator' option must be undefined, or a boolean.",
);
}
if (typeof useRuntimeHelpers !== "boolean") {
throw new Error("The 'helpers' option must be undefined, or a boolean.");
}
if (typeof useESModules !== "boolean" && useESModules !== "auto") {
throw new Error(
"The 'useESModules' option must be undefined, or a boolean, or 'auto'.",
);
}
if (
typeof absoluteRuntime !== "boolean" &&
typeof absoluteRuntime !== "string"
@@ -64,16 +92,7 @@ export default declare((api, options, dirname) => {
"The 'absoluteRuntime' option must be undefined, a boolean, or a string.",
);
}
if (
corejsVersion !== false &&
(typeof corejsVersion !== "number" || corejsVersion !== 2) &&
(typeof corejsVersion !== "string" || corejsVersion !== "2")
) {
throw new Error(
`The 'corejs' option must be undefined, false, 2 or '2', ` +
`but got ${JSON.stringify(corejsVersion)}.`,
);
}
if (typeof runtimeVersion !== "string") {
throw new Error(`The 'version' option must be a version string.`);
}
@@ -81,6 +100,18 @@ export default declare((api, options, dirname) => {
function has(obj, key) {
return Object.prototype.hasOwnProperty.call(obj, key);
}
function hasMapping(methods, name) {
return has(methods, name) && (proposals || methods[name].stable);
}
function hasStaticMapping(object, method) {
return (
has(StaticProperties, object) &&
hasMapping(StaticProperties[object], method)
);
}
if (has(options, "useBuiltIns")) {
if (options.useBuiltIns) {
throw new Error(
@@ -90,10 +121,11 @@ export default declare((api, options, dirname) => {
} else {
throw new Error(
"The 'useBuiltIns' option has been removed. Use the 'corejs'" +
"option with value '2' to polyfill with CoreJS 2.x via @babel/runtime.",
"option to polyfill with `core-js` via @babel/runtime.",
);
}
}
if (has(options, "polyfill")) {
if (options.polyfill === false) {
throw new Error(
@@ -103,10 +135,11 @@ export default declare((api, options, dirname) => {
} else {
throw new Error(
"The 'polyfill' option has been removed. Use the 'corejs'" +
"option with value '2' to polyfill with CoreJS 2.x via @babel/runtime.",
"option to polyfill with `core-js` via @babel/runtime.",
);
}
}
if (has(options, "moduleName")) {
throw new Error(
"The 'moduleName' option has been removed. @babel/transform-runtime " +
@@ -119,11 +152,22 @@ export default declare((api, options, dirname) => {
const esModules =
useESModules === "auto" ? api.caller(supportsStaticESM) : useESModules;
const injectCoreJS2 = `${corejsVersion}` === "2";
const moduleName = injectCoreJS2
const injectCoreJS2 = corejsVersion === 2;
const injectCoreJS3 = corejsVersion === 3;
const injectCoreJS = corejsVersion !== false;
const moduleName = injectCoreJS3
? "@babel/runtime-corejs3"
: injectCoreJS2
? "@babel/runtime-corejs2"
: "@babel/runtime";
const corejsRoot = injectCoreJS3 && !proposals ? "core-js-stable" : "core-js";
const { BuiltIns, StaticProperties, InstanceProperties } = (injectCoreJS2
? getCoreJS2Definitions
: getCoreJS3Definitions)(runtimeVersion);
const HEADER_HELPERS = ["interopRequireWildcard", "interopRequireDefault"];
let modulePath = moduleName;
@@ -199,7 +243,10 @@ export default declare((api, options, dirname) => {
visitor: {
ReferencedIdentifier(path) {
const { node, parent, scope } = path;
if (node.name === "regeneratorRuntime" && useRuntimeRegenerator) {
const { name } = node;
// transform `regeneratorRuntime`
if (name === "regeneratorRuntime" && useRuntimeRegenerator) {
path.replaceWith(
this.addDefaultImport(
`${modulePath}/regenerator`,
@@ -209,50 +256,81 @@ export default declare((api, options, dirname) => {
return;
}
if (!injectCoreJS2) return;
if (!injectCoreJS) return;
if (t.isMemberExpression(parent)) return;
if (!has(definitions.builtins, node.name)) return;
if (scope.getBindingIdentifier(node.name)) return;
if (!hasMapping(BuiltIns, name)) return;
if (scope.getBindingIdentifier(name)) return;
// Symbol() -> _core.Symbol(); new Promise -> new _core.Promise
// transform global built-ins like `Symbol()`, `new Promise`
path.replaceWith(
this.addDefaultImport(
`${modulePath}/core-js/${definitions.builtins[node.name]}`,
node.name,
`${modulePath}/${corejsRoot}/${BuiltIns[name].path}`,
name,
),
);
},
// arr[Symbol.iterator]() -> _core.$for.getIterator(arr)
CallExpression(path) {
if (!injectCoreJS2) return;
if (!injectCoreJS) return;
// we can't compile this
if (path.node.arguments.length) return;
const { node } = path;
const { callee } = node;
const callee = path.node.callee;
if (!t.isMemberExpression(callee)) return;
const { object, property } = callee;
const propertyName = property.name;
// transform calling instance methods like `something.includes()`
if (injectCoreJS3 && !hasStaticMapping(object.name, propertyName)) {
if (hasMapping(InstanceProperties, propertyName)) {
let context1, context2;
if (t.isIdentifier(object)) {
context1 = object;
context2 = t.cloneNode(object);
} else {
context1 = path.scope.generateDeclaredUidIdentifier("context");
context2 = t.assignmentExpression("=", context1, object);
}
node.callee = t.memberExpression(
t.callExpression(
this.addDefaultImport(
`${moduleName}/${corejsRoot}/instance/${
InstanceProperties[propertyName].path
}`,
`${propertyName}InstanceProperty`,
),
[context2],
),
t.identifier("call"),
);
node.arguments.unshift(context1);
return;
}
}
// we can't compile this
if (node.arguments.length) return;
if (!callee.computed) return;
if (!path.get("callee.property").matchesPattern("Symbol.iterator")) {
return;
}
// transform `something[Symbol.iterator]()` to calling `getIterator(something)` helper
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${modulePath}/core-js/get-iterator`,
"getIterator",
),
[callee.object],
[object],
),
);
},
// Symbol.iterator in arr -> core.$for.isIterable(arr)
// transform `Symbol.iterator in something` to calling `isIterable(something)` helper
BinaryExpression(path) {
if (!injectCoreJS2) return;
if (!injectCoreJS) return;
if (path.node.operator !== "in") return;
if (!path.get("left").matchesPattern("Symbol.iterator")) return;
@@ -267,61 +345,84 @@ export default declare((api, options, dirname) => {
);
},
// Array.from -> _core.Array.from
// transform static built-ins methods like `Array.from`
MemberExpression: {
enter(path) {
if (!injectCoreJS2) return;
if (!injectCoreJS) return;
if (!path.isReferenced()) return;
const { node } = path;
const obj = node.object;
const prop = node.property;
const { object, property } = node;
if (!t.isReferenced(obj, node)) return;
if (node.computed) return;
if (!has(definitions.methods, obj.name)) return;
if (!t.isReferenced(object, node)) return;
const methods = definitions.methods[obj.name];
if (!has(methods, prop.name)) return;
// doesn't reference the global
if (path.scope.getBindingIdentifier(obj.name)) return;
// special case Object.defineProperty to not use core-js when using string keys
if (
obj.name === "Object" &&
prop.name === "defineProperty" &&
path.parentPath.isCallExpression()
) {
const call = path.parentPath.node;
if (call.arguments.length === 3 && t.isLiteral(call.arguments[1])) {
return;
if (node.computed) {
if (injectCoreJS2) return;
// transform `something[Symbol.iterator]` to calling `getIteratorMethod(something)` helper
if (path.get("property").matchesPattern("Symbol.iterator")) {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/core-js/get-iterator-method`,
"getIteratorMethod",
),
[object],
),
);
}
return;
}
const objectName = object.name;
const propertyName = property.name;
// doesn't reference the global
if (
path.scope.getBindingIdentifier(objectName) ||
!hasStaticMapping(objectName, propertyName)
) {
// transform getting of instance methods like `method = something.includes`
if (injectCoreJS3 && hasMapping(InstanceProperties, propertyName)) {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/${corejsRoot}/instance/${
InstanceProperties[propertyName].path
}`,
`${propertyName}InstanceProperty`,
),
[object],
),
);
}
return;
}
path.replaceWith(
this.addDefaultImport(
`${modulePath}/core-js/${methods[prop.name]}`,
`${obj.name}$${prop.name}`,
`${modulePath}/${corejsRoot}/${
StaticProperties[objectName][propertyName].path
}`,
`${objectName}$${propertyName}`,
),
);
},
exit(path) {
if (!injectCoreJS2) return;
if (!injectCoreJS) return;
if (!path.isReferenced()) return;
const { node } = path;
const obj = node.object;
const { object } = node;
const { name } = object;
if (!has(definitions.builtins, obj.name)) return;
if (path.scope.getBindingIdentifier(obj.name)) return;
if (!hasMapping(BuiltIns, name)) return;
if (path.scope.getBindingIdentifier(name)) return;
path.replaceWith(
t.memberExpression(
this.addDefaultImport(
`${modulePath}/core-js/${definitions.builtins[obj.name]}`,
obj.name,
`${modulePath}/${corejsRoot}/${BuiltIns[name].path}`,
name,
),
node.property,
node.computed,