From 2e0f64256f00420a843cdc54499350a5d7c8187f Mon Sep 17 00:00:00 2001 From: Brian Ng Date: Mon, 27 Feb 2017 14:02:41 -0600 Subject: [PATCH] Use invariant for invalid electron version --- experimental/babel-preset-env/src/index.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/experimental/babel-preset-env/src/index.js b/experimental/babel-preset-env/src/index.js index 6054b54675..2ce8be2a86 100644 --- a/experimental/babel-preset-env/src/index.js +++ b/experimental/babel-preset-env/src/index.js @@ -1,4 +1,5 @@ import browserslist from "browserslist"; +import invariant from "invariant"; import builtInsList from "../data/built-ins.json"; import defaultInclude from "./default-includes"; import { electronToChromium } from "electron-to-chromium"; @@ -101,19 +102,18 @@ export const getTargets = (targets = {}) => { targetOps.node = getCurrentNodeVersion(); } - // Rewrite Electron versions to their Chrome equivalents + // Replace Electron versions with their Chrome equivalent if (targetOps.electron) { const electronChromeVersion = parseInt(electronToChromium(targetOps.electron), 10); - if (!electronChromeVersion) { - throw new Error(`Electron version ${targetOps.electron} is either too old or too new`); - } + invariant( + !!electronChromeVersion, + `Electron version ${targetOps.electron} is either too old or too new` + ); - if (targetOps.chrome) { - targetOps.chrome = Math.min(targetOps.chrome, electronChromeVersion); - } else { - targetOps.chrome = electronChromeVersion; - } + targetOps.chrome = targetOps.chrome + ? Math.min(targetOps.chrome, electronChromeVersion) + : electronChromeVersion; delete targetOps.electron; }