linting: disallow t.identifier("undefined") in plugins (#6096)

* add new custom eslint rule, replace remaining t.identifier("undefined") with buildUndefinedNode(), update tests * change no-undefined-identifier reporting descriptor
2017-08-24 15:43:01 -04:00
parent 4577bd1b7c
commit 2db0c3ad1d
41 changed files with 105 additions and 53 deletions
--- a/packages/babel-plugin-transform-es2015-destructuring/src/index.js
+++ b/packages/babel-plugin-transform-es2015-destructuring/src/index.js
@@ -112,7 +112,11 @@ export default function({ types: t }) {
      //

      const tempConditional = t.conditionalExpression(
-        t.binaryExpression("===", tempValueRef, t.identifier("undefined")),
+        t.binaryExpression(
+          "===",
+          tempValueRef,
+          this.scope.buildUndefinedNode(),
+        ),
        pattern.right,
        tempValueRef,
      );