From 2d36d8b6165b3b2536b06a9bbfcc7ea2509cf0dd Mon Sep 17 00:00:00 2001 From: Amjad Masad Date: Tue, 27 Oct 2015 17:24:45 -0700 Subject: [PATCH] If binary expression precedence is equal no need for parens. Fixes #2602 --- packages/babel/src/generation/node/parentheses.js | 4 ---- .../test/fixtures/generation/parentheses/expression/actual.js | 1 + .../fixtures/generation/parentheses/expression/expected.js | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) create mode 100644 packages/babel/test/fixtures/generation/parentheses/expression/actual.js create mode 100644 packages/babel/test/fixtures/generation/parentheses/expression/expected.js diff --git a/packages/babel/src/generation/node/parentheses.js b/packages/babel/src/generation/node/parentheses.js index 44201e11fb..012184f020 100644 --- a/packages/babel/src/generation/node/parentheses.js +++ b/packages/babel/src/generation/node/parentheses.js @@ -97,10 +97,6 @@ export function Binary(node, parent) { if (parentPos > nodePos) { return true; } - - if (parentPos === nodePos && parent.right === node) { - return true; - } } } diff --git a/packages/babel/test/fixtures/generation/parentheses/expression/actual.js b/packages/babel/test/fixtures/generation/parentheses/expression/actual.js new file mode 100644 index 0000000000..8a2b727e0e --- /dev/null +++ b/packages/babel/test/fixtures/generation/parentheses/expression/actual.js @@ -0,0 +1 @@ +a && (a.b && a.b.c()); diff --git a/packages/babel/test/fixtures/generation/parentheses/expression/expected.js b/packages/babel/test/fixtures/generation/parentheses/expression/expected.js new file mode 100644 index 0000000000..56580c5211 --- /dev/null +++ b/packages/babel/test/fixtures/generation/parentheses/expression/expected.js @@ -0,0 +1 @@ +a && a.b && a.b.c();