cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not access out of bounds arguments (#6792)

Browse Source 
Potentially out of bounds arguments should not just be directly
accessed, instead use a ternary operator to check length.
This commit is contained in:
Anatoli Papirovski
2017-11-17 15:39:08 -05:00
committed by Nicolò Ribaudo
parent e67cfc5b31
commit 2b710d0387
5 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/babel-plugin-transform-parameters/src/params.js
View File

@@ -19,8 +19,8 @@ const buildLooseDestructuredDefaultParam = template(`
let ASSIGNMENT_IDENTIFIER = PARAMETER_NAME === UNDEFINED ? DEFAULT_VALUE : PARAMETER_NAME ;
`);
const buildArgumentsAccess = template(`
let $0 = arguments[$1];
const buildSafeArgumentsAccess = template(`
let $0 = arguments.length > $1 ? arguments[$1] : undefined;
`);
function isSafeBinding(scope, node) {
@@ -110,7 +110,10 @@ export default function convertFunctionParams(path, loose) {
});
body.push(defNode);
} else if (firstOptionalIndex !== null) {
const defNode = buildArgumentsAccess([param.node, t.numericLiteral(i)]);
const defNode = buildSafeArgumentsAccess([
param.node,
t.numericLiteral(i),
]);
body.push(defNode);
} else if (param.isObjectPattern() || param.isArrayPattern()) {
const uid = path.scope.generateUidIdentifier("ref");