cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

make illegal LHS pattern error messages more user friendly

Browse Source
This commit is contained in:
Sebastian McKenzie 2015-04-13 16:40:13 -07:00
parent 075ff67aca
commit 28589d459d
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/expression.js
View File

@ -103,8 +103,16 @@ pp.parseMaybeAssign = function(noIn, refShorthandDefaultPos, afterLeftParse) {
node.left = this.type === tt.eq ? this.toAssignable(left) : left
refShorthandDefaultPos.start = 0 // reset because shorthand default was used correctly
this.checkLVal(left)
if (left.parenthesizedExpression && (left.type === "ObjectPattern" || left.type === "ArrayPattern")) {
this.raise(left.start, "You're trying to assign to a parenthesized expression, instead of `({ foo }) = {}` use `({ foo } = {})`");
if (left.parenthesizedExpression) {
let errorMsg
if (left.type === "ObjectPattern") {
errorMsg = "`({a}) = 0` use `({a} = 0)`"
} else if (left.type === "ArrayPattern") {
errorMsg = "`([a]) = 0` use `([a] = 0)`"
}
if (errorMsg) {
this.raise(left.start, `You're trying to assign to a parenthesized expression, eg. instead of ${errorMsg}`)
}
}
this.next()
node.right = this.parseMaybeAssign(noIn)