cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Limit file-based plugins/presets to only exporting functions. (#6494)

Browse Source
This commit is contained in:
Logan Smyth 2017-10-18 10:17:45 -07:00 committed by GitHub
parent 445b252bc4
commit 1b4307205e
32 changed files with 158 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/babel-core/src/config/option-manager.js
View File

@ -556,6 +556,15 @@ function normalizePair(
);
}
if (filepath !== null && typeof value === "object" && value) {
// We allow object values for plugins/presets nested directly within a
// config object, because it can be useful to define them in nested
// configuration contexts.
throw new Error(
"Plugin/Preset files are not allowed to export objects, only functions.",
);
}
if (options != null && typeof options !== "object") {
throw new Error(
"Plugin/Preset options must be an object, null, or undefined",

6
packages/babel-core/test/fixtures/option-manager/presets/es2015_default_object.js vendored
View File

@ -7,6 +7,8 @@
'use strict';
exports.__esModule = true;
exports.default = {
plugins: [require('../../../../../babel-plugin-syntax-decorators')]
module.exports = function() {
return {
plugins: [require('../../../../../babel-plugin-syntax-decorators')]
};
};

10
packages/babel-core/test/fixtures/option-manager/presets/es5_object.js vendored
View File

@ -1,5 +1,7 @@
module.exports = {
plugins: [
require('../../../../../babel-plugin-syntax-decorators'),
]
module.exports = function() {
return {
plugins: [
require('../../../../../babel-plugin-syntax-decorators'),
]
};
};

3
packages/babel-core/test/fixtures/resolution/babel-org-paths/node_modules/@babel/plugin-foo/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/babel-org-paths/node_modules/@babel/preset-foo/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/babel-scoped-nested-module-paths/node_modules/@babel/mod/plugin.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/babel-scoped-nested-module-paths/node_modules/@babel/mod/preset.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/foo-org-paths/node_modules/@foo/babel-plugin-mod/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/foo-org-paths/node_modules/@foo/babel-preset-mod/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/module-paths/node_modules/plugin/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/module-paths/node_modules/preset/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/nested-module-paths/node_modules/mod/plugin.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/nested-module-paths/node_modules/mod/preset.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/relative-paths/dir/plugin.js vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/relative-paths/dir/preset.js vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/scoped-nested-module-paths/node_modules/@foo/mod/plugin.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/scoped-nested-module-paths/node_modules/@foo/mod/preset.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/standard-paths/node_modules/babel-plugin-mod/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/standard-paths/node_modules/babel-preset-mod/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/throw-babel-paths/node_modules/@babel/plugin-foo/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/throw-babel-paths/node_modules/@babel/preset-foo/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/throw-module-paths/node_modules/foo/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/throw-opposite-paths/node_modules/babel-plugin-testplugin/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

3
packages/babel-core/test/fixtures/resolution/throw-opposite-paths/node_modules/babel-preset-testpreset/index.js generated vendored
View File

@ -0,0 +1,3 @@
module.exports = function() {
return {};
};

16
packages/babel-helpers/test/fixtures/dependencies/basic/plugin.js vendored
View File

@ -12,12 +12,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/deep/plugin.js vendored
View File

@ -17,12 +17,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/missing/plugin.js vendored
View File

@ -8,12 +8,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/multiple/plugin.js vendored
View File

@ -17,12 +17,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/rename-binding-equal/plugin.js vendored
View File

@ -15,12 +15,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/rename-deep-global/plugin.js vendored
View File

@ -14,12 +14,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};

24
packages/babel-helpers/test/fixtures/dependencies/reuse-dependency/plugin.js vendored
View File

@ -12,16 +12,18 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name === "REPLACE_ME_1") {
const mainHelper = this.addHelper(main);
path.replaceWith(mainHelper);
} else if (path.node.name === "REPLACE_ME_2") {
const dependencyHelper = this.addHelper(dependency);
path.replaceWith(dependencyHelper);
}
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name === "REPLACE_ME_1") {
const mainHelper = this.addHelper(main);
path.replaceWith(mainHelper);
} else if (path.node.name === "REPLACE_ME_2") {
const dependencyHelper = this.addHelper(dependency);
path.replaceWith(dependencyHelper);
}
},
},
},
};
};

16
packages/babel-helpers/test/fixtures/dependencies/variable-same-name-dependency/plugin.js vendored
View File

@ -15,12 +15,14 @@ const main = defineHelper(__dirname, "main", `
}
`);
module.exports = {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
module.exports = function() {
return {
visitor: {
Identifier(path) {
if (path.node.name !== "REPLACE_ME") return;
const helper = this.addHelper(main);
path.replaceWith(helper);
},
},
},
};
};