From 19b05b5e610ee15755409764813409d4d4de9fd7 Mon Sep 17 00:00:00 2001 From: Sebastian McKenzie Date: Sun, 10 May 2015 19:35:05 +0100 Subject: [PATCH] change some manual array for loops to for..of --- src/babel/generation/generators/statements.js | 4 ++-- src/babel/traversal/path/index.js | 2 +- src/babel/traversal/scope.js | 7 +++---- src/babel/util.js | 8 ++++---- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/src/babel/generation/generators/statements.js b/src/babel/generation/generators/statements.js index 81ba6f2c83..4f0362a38c 100644 --- a/src/babel/generation/generators/statements.js +++ b/src/babel/generation/generators/statements.js @@ -182,8 +182,8 @@ export function VariableDeclaration(node, print, parent) { var hasInits = false; // don't add whitespace to loop heads if (!t.isFor(parent)) { - for (var i = 0; i < node.declarations.length; i++) { - if (node.declarations[i].init) { + for (var declar of (node.declarations: Array)) { + if (declar.init) { // has an init so let's split it up over multiple lines hasInits = true; } diff --git a/src/babel/traversal/path/index.js b/src/babel/traversal/path/index.js index 4b1dba5972..63e029e34c 100644 --- a/src/babel/traversal/path/index.js +++ b/src/babel/traversal/path/index.js @@ -29,7 +29,7 @@ var hoistVariablesVisitor = explode({ var exprs = []; - for (var i = 0; i < node.declarations.length; i++) { + for (var declar of (node.declarations: Array)) { var declar = node.declarations[i]; if (declar.init) { exprs.push(t.expressionStatement( diff --git a/src/babel/traversal/scope.js b/src/babel/traversal/scope.js index 7af484f2e0..ce75f9ece3 100644 --- a/src/babel/traversal/scope.js +++ b/src/babel/traversal/scope.js @@ -265,8 +265,8 @@ export default class Scope { if (node.source) { add(node.source); } else if (node.specifiers && node.specifiers.length) { - for (var i = 0; i < node.specifiers.length; i++) { - add(node.specifiers[i]); + for (var specifier of (node.specifiers: Array)) { + add(specifier); } } else if (node.declaration) { add(node.declaration); @@ -283,8 +283,7 @@ export default class Scope { } else if (t.isCallExpression(node)) { add(node.callee); } else if (t.isObjectExpression(node) || t.isObjectPattern(node)) { - for (var i = 0; i < node.properties.length; i++) { - var prop = node.properties[i]; + for (var prop of (node.properties: Array)) { add(prop.key || prop.argument); } } diff --git a/src/babel/util.js b/src/babel/util.js index f92aabadd5..6b03bc0aa0 100644 --- a/src/babel/util.js +++ b/src/babel/util.js @@ -97,13 +97,13 @@ export function booleanify(val: any): boolean { export function shouldIgnore(filename, ignore, only) { filename = slash(filename); if (only.length) { - for (var i = 0; i < only.length; i++) { - if (only[i].test(filename)) return false; + for (var pattern of (only: Array)) { + if (pattern.test(filename)) return false; } return true; } else if (ignore.length) { - for (var i = 0; i < ignore.length; i++) { - if (ignore[i].test(filename)) return true; + for (var pattern of (ignore: Array)) { + if (pattern.test(filename)) return true; } }